This repository was archived by the owner on Dec 8, 2025. It is now read-only.
Repository navigation
Set build jobs to use ubuntu-latest runners - #6
Merged
Merged
Conversation
The current runners never get picked up - presumably, fac doesn't have any available. Switch them to ubuntu-latest, like the rest of our repos. At the same time, disable via if: false the jobs that would do deployment steps
asilano
marked this pull request as ready for review
September 10, 2025 08:52
singhprd
approved these changes
Sep 10, 2025
| @@ -93,10 +93,10 @@ test/fixtures/multiple-rule-offenses.html.erb:5:3 | |||
| test/fixtures/multiple-rule-offenses.html.erb:10:1 | |||
|
|
|||
| 8 │ <h1></h1> | |||
Collaborator
Author
There was a problem hiding this comment.
Yes. The test step compares the linter output against a snapshot. Somewhere down the line, some trailing spaces got added / lost on the snapshot and it no longer matched. I've regenerated it so the CI tests pass.
|
Yeah If you need bigger ones we have those too. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current runners never get picked up - presumably, fac doesn't have any available. Switch them to ubuntu-latest, like the rest of our repos.
At the same time, disable via if: false the jobs that would do deployment steps