Remove unused type error suppressions - mcrouter

Summary:
This diff was automatically generated by the Pyre per-target upgrade tool.

It removes `# pyre-fixme` or `pyrefly: ignore` comments that are no longer needed because the underlying type errors have been resolved.
Note that it will also aim to ensure type checking runs cleanly, and will add suppressions to existing type errors.

#pyreupgrade

Differential Revision: D116540362

fbshipit-source-id: 55c6c0413defe6bcb4af58e5704912c0bef7d003

Author: generatedunixname89002005307016

mcrouter/test/MCProcess.py

@@ -92,9 +92,7 @@ def resume(self):
             self.proc.send_signal(signal.SIGCONT)
 
     def is_alive(self):
-        # pyrefly: ignore [missing-attribute]
         self.proc.poll()
-        # pyrefly: ignore [missing-attribute]
         return self.proc.returncode is None
 
     def get_log(self):
@@ -115,7 +113,6 @@ def dump(self):
         default) so we can debug better."""
 
         try:
-            # pyrefly: ignore [missing-attribute]
             stdout, stderr = self.proc.communicate()
         except Exception:
             stdout, stderr = b"", b""
@@ -187,24 +184,20 @@ def __init__(
                 addr="::1", port=thriftPort
             )
         else:
-            # pyrefly: ignore [bad-assignment]
             self.thrift_client = None
 
     def _sendall(self, s):
         if type(s) is not bytes:
             s = s.encode("utf8")
-        # pyrefly: ignore [missing-attribute]
         self.socket.sendall(s)
 
     def _fdread(self, n):
-        # pyrefly: ignore [missing-attribute]
         data = self.fd.read(n)
         if data is not None and type(data) is not str:
             data = data.decode("utf8", errors="backslashreplace")
         return data
 
     def _fdreadline(self):
-        # pyrefly: ignore [missing-attribute]
         data = self.fd.readline()
         if data is not None and type(data) is not str:
             data = data.decode("utf8")
@@ -250,7 +243,6 @@ def ensure_connected(self):
                 except Exception as e:
                     retry_count += 1
                     print(
-                        # pyrefly: ignore [missing-attribute]
                         f"Cannot connect (errno: {e.errno}). Retry {retry_count} of {self.max_retries}."
                     )
                     self.disconnect()
@@ -362,10 +354,8 @@ def _get(self, cmd, keys, expect_cas, return_all_info):
                 payload = self._fdread(n)
                 self._fdread(2)
                 if return_all_info:
-                    # pyrefly: ignore [unsupported-operation]
                     res[k] = dict({"key": k, "flags": f, "size": n, "value": payload})
                     if expect_cas:
-                        # pyrefly: ignore [unsupported-operation]
                         res[k]["cas"] = int(parts[4])
                 else:
                     res[k] = payload
@@ -436,20 +426,16 @@ def leaseGet(self, keys):
             elif line.startswith("VALUE"):
                 v, k, f, n = line.split()
                 assert k in keys
-                # pyrefly: ignore [unsupported-operation]
                 res[k] = {"value": self._fdread(int(n)), "token": None}
                 self._fdread(2)
             elif line.startswith("LVALUE"):
                 v, k, t, f, n = line.split()
                 assert k in keys
-                # pyrefly: ignore [unsupported-operation]
                 res[k] = {"value": self._fdread(int(n)), "token": int(t)}
 
     def expectNoReply(self):
-        # pyrefly: ignore [missing-attribute]
         self.socket.settimeout(0.5)
         try:
-            # pyrefly: ignore [missing-attribute]
             self.socket.recv(1)
             return False
         except TimeoutError:
@@ -965,9 +951,7 @@ def is_alive():
                     return os.path.exists(f"/proc/{pid}")
                 return False
 
-            # pyrefly: ignore [bad-assignment, bad-override]
             self.terminate = terminate
-            # pyrefly: ignore [bad-assignment, bad-override]
             self.is_alive = is_alive
 
         if substitute_config_smc_ports and sr_mock_smc_config:
@@ -1075,10 +1059,8 @@ def __init__(
 
         MCProcess.__init__(self, args, asyncPort, pass_fds=pass_fds)
 
-        # pyrefly: ignore [unbound-name]
         if listenSocketThrift is not None:
             listenSocketThrift.close()
-        # pyrefly: ignore [unbound-name]
         if listenSocketAsyncMc is not None:
             listenSocketAsyncMc.close()
 
@@ -1100,9 +1082,7 @@ def __init__(self, fifos_dir, extra_args=None):
 
     def output(self):
         if not hasattr(self, "stdout"):
-            # pyrefly: ignore [missing-attribute]
             self.proc.terminate()
-            # pyrefly: ignore [missing-attribute]
             self.stdout = self.proc.stdout.read().decode("ascii", errors="ignore")
         return self.stdout
 

mcrouter/test/McrouterTestCase.py

@@ -137,7 +137,6 @@ def eventually_get(self, key, expVal, retries=20):
         start_time = time.time()
         interval = 0.5
         while retries > 0:
-            # pyrefly: ignore [missing-attribute]
             if self.mc.get(key) == expVal:
                 return True
             time.sleep(interval)

mcrouter/test/mock_servers.py

@@ -55,7 +55,6 @@ def run(self):
             try:
                 client, address = self.listen_socket.accept()
                 client.setsockopt(socket.IPPROTO_TCP, socket.TCP_NODELAY, 1)
-                # pyrefly: ignore [missing-attribute]
                 self.runServer(client, address)
                 client.close()
             except OSError as e:

mcrouter/test/test_bad_params.py

@@ -40,7 +40,6 @@ def timeout_handler(signum, frame):
         signal.signal(signal.SIGALRM, timeout_handler)
         signal.alarm(timeout)
 
-        # pyrefly: ignore [missing-attribute]
         for line in self.proc.stderr:
             line = line.decode()
             stderr += line

mcrouter/test/test_linenumbers.py

@@ -50,7 +50,6 @@ def spawn(self, cmd):
         self.proc = subprocess.Popen(cmd, stderr=subprocess.PIPE)
 
     def check_for_error_line_number(self):
-        # pyrefly: ignore [missing-attribute]
         for line in self.proc.stderr:
             line = line.decode()
             if "Unknown RouteHandle: XYZRoute line: 3" in line:

mcrouter/test/test_mcrouter_basic.py

@@ -146,11 +146,9 @@ def test_double_bind(self):
         mcr2 = Mcrouter(self.null_route_config, port=mcr1.port)
         self.assertTrue(mcr1.is_alive())
         retries = 20
-        # pyrefly: ignore [missing-argument]
         while mcr2.is_alive() and retries > 0:
             retries = retries - 1
             time.sleep(1)
-        # pyrefly: ignore [missing-argument]
         self.assertFalse(mcr2.is_alive())
 
     def test_set_exptime(self):

mcrouter/test/test_mcrouter_errors.py

@@ -354,7 +354,6 @@ def connect(self, addr):
                 sock.connect(addr)
                 return sock
             except Exception as e:
-                # pyrefly: ignore [missing-attribute]
                 if e.errno == errno.ECONNREFUSED:
                     pass
                 else: