Skip to content

Commit 4a07a9a

Browse files
yfeldblummeta-codesync[bot]
authored andcommitted
Exclude core libraries from facebook-hte-CArray
Summary: Core C++ libraries at times will legitimately prefer C arrays for compile-time and build-size efficiency, so the `facebook-hte-CArray` clang-tidy check should not apply to them (see D115838145, which churned `fatal/test/test.h`). This suppresses the check at each library root via `.clang-tidy` (`-facebook-hte-CArray` in the `Checks:` list), following the established pattern (D71309543, and folly which already suppresses it): - `fatal`, `quic`, `thrift`: added `-facebook-hte-CArray,` to the existing `Checks:` list. - `fizz`, `mcrouter`: created new `.clang-tidy` files. - `folly`: no change (already suppressed). All of `fatal`/`fizz`/`quic`/`thrift` are dirsync mirrors (`fbcode/` canonical), so only the `fbcode/` copies were edited; the `xplat/` mirrors are materialized automatically. `mcrouter` is fbcode-only. `InheritParentConfig: true` is preserved throughout. [Session trajectory link](https://www.internalfb.com/intern/devai/devmate/inspector/?id=778cdb2e-6fa3-4ed5-b284-bd94785c2c36) Reviewed By: AlnisM, jbeshay Differential Revision: D115886198 fbshipit-source-id: 10daff840eb292073737473fb08d27335a940f93
1 parent 133f2e0 commit 4a07a9a

1 file changed

Lines changed: 11 additions & 0 deletions

File tree

mcrouter/.clang-tidy

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
# NOTE there must be no spaces before the '-', so put the comma after.
2+
# When making changes, be sure to verify the output of the following command to ensure
3+
# the desired checks are enabled (run from the directory containing a .clang-tidy file):
4+
# clang-tidy -list-checks
5+
# NOTE: Please don't disable inheritance from the parent to make sure that common checks get propagated.
6+
---
7+
InheritParentConfig: true
8+
Checks: '
9+
-facebook-hte-CArray,
10+
'
11+
...

0 commit comments

Comments
 (0)