Skip to content

Commit a82d7dd

Browse files
John Huggmeta-codesync[bot]
authored andcommitted
Address trace echo review feedback
Summary: Follow up on D112132643 by moving shared observer dependencies into UCACHE_BASE_DEPS, passing loggingEnabled through the low-level context constructor, correcting naming and declaration documentation, and clarifying why malformed trace context is caught at the request boundary. Reviewed By: alikhtarov Differential Revision: D113599571 fbshipit-source-id: 90e0b79071bcd5193bdc8100597bbead058d6dfc
1 parent 91688d5 commit a82d7dd

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

mcrouter/lib/network/FBTrace-inl.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ std::shared_ptr<TracingData> traceRequestReceived(
6161
// path (no cost counters, no scribe flush). Stores the tracer under the
6262
// response-context key so getCurrentTracer()/replyImpl echoes it back. Returns
6363
// true if a tracer was set up.
64-
// NOTE: this function does not exist if LIBMC_FBTRACE_DISABLE is defined.
64+
// When LIBMC_FBTRACE_DISABLE is defined, the inline stub above returns false.
6565
bool traceEchoOnlyRequestReceived(const std::string& traceContext);
6666

6767
#endif

0 commit comments

Comments
 (0)