Pytorch typehints?

[michaelfortunato]

Hi all,
I am a big fan of pyrefly. I have a question about pytorch type hints and I am not sure if they are particular to pyrefly or not, but any help would be appreciated. torch.zeros is a valid function in pytorch top level module. However, I get no suggestion completion for torch.zeros. See the photo below:

I asked the ai slop bots and they said it might be due to torch.zeros being a function defined in C? Is there a way I can get pyrefly to recognize torch.zeros. Thanks

[michaelfortunato]

Hover works by the way.

[rchen152]

Hey @michaelfortunato! Sorry for the slow response. It looks like type information for torch.zeros is generated by https://github.com/pytorch/pytorch/blob/main/tools/pyi/gen_pyi.py and put into generated file torch/_C/_VariableFunctions.pyi, whose contents are then imported here: https://github.com/pytorch/pytorch/blob/14c7358c645880196f54f84586975c6407ed3f40/torch/__init__.py#L2099. I'm not sure why completion isn't working, but it seems like a bug in Pyrefly. I'll open an issue.

[rchen152]

#865 is the issue. Any information you could provide about your environment (such as what editor you're using, what version of pyrefly) would be really helpful.

[michaelfortunato]

Yes. I am using neovim with a plugin called blink.cmp that provides me completions.
I didn't post it as an issue because I was unsure if it was my editor setup causing the issue or just something neovim specific.
I haven't created a minimal reproduction of it. But here would be the steps.
Setup the environment

uv venv 
source .venv/bin/activate
uv pip install torch
uv tool install pyrefly

Set up your IDE for pyrefly.
Open

import torch
torch.zer

See if a completion comes up if you move the cursor the the end of the last line in the python file.

Thanks!

[rchen152]

Thank you!

[WayenVan]

I also encounter this problem when I'm editing files inside a ofiicial pytorck docker containers with neovim, both torch and numpy are having this problem. The docker image is pytorch/pytorch:2.4.0-cuda11.8-cudnn9-devel

[lolpack]

@michaelfortunato this is fixed in 0.29.2. Thank you for raising this and please report anything else you might see.

Thank you @grievejia and @kinto0 for debugging and fixing!

[michaelfortunato]

Yes! Works great! Thanks everyone.

[michaelfortunato]

This is super nice. Thanks again

[WayenVan]

I can confirm it is fixed, finnaly I can leave pyright.