chore(deps): update dependency @vitest/eslint-plugin to v1.6.3 (#3645)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: xDivisionByZerox <leyla.jaehnig@gmx.de>

Author: renovate[bot]

eslint.config.ts

@@ -255,10 +255,7 @@ export default defineConfig(
   {
     name: 'test/**/*.ts overrides',
     files: ['test/**/*.spec.ts', 'test/**/*.spec.cts', 'test/**/*.spec.d.ts'],
-    plugins: {
-      // @ts-expect-error: weird type error
-      vitest: eslintPluginVitest,
-    },
+    extends: [eslintPluginVitest.configs.recommended],
     rules: {
       '@typescript-eslint/no-deprecated': 'off',
 
@@ -271,10 +268,9 @@ export default defineConfig(
         },
       ],
 
-      ...eslintPluginVitest.configs.recommended.rules,
-
       'vitest/expect-expect': 'off',
       'vitest/no-alias-methods': 'error',
+      'vitest/no-conditional-expect': 'off', // we require conditional logic when iterating over faker instances or instances in diffent versions (for the docs)
       'vitest/prefer-each': 'error',
       'vitest/prefer-to-have-length': 'error',
       'vitest/valid-expect': ['error', { maxArgs: 2 }],

package.json

@@ -106,7 +106,7 @@
     "@types/semver": "7.7.1",
     "@types/validator": "13.15.10",
     "@vitest/coverage-v8": "3.2.4",
-    "@vitest/eslint-plugin": "1.3.20",
+    "@vitest/eslint-plugin": "1.6.3",
     "@vitest/ui": "3.2.4",
     "@vueuse/core": "13.9.0",
     "commit-and-tag-version": "12.6.1",

pnpm-lock.yaml

@@ -55,16 +55,16 @@ describe('faker', () => {
       // Non-existing module
       expect(faker.definitions.missing).toBeDefined();
       // Non-existing definition in a non-existing module
-      expect(() => faker.definitions.missing?.missing).toThrow();
+      expect(() => faker.definitions.missing?.missing).toThrowError();
       // Non-existing definition in an existing module
-      expect(() => faker.definitions.location.missing).toThrow();
+      expect(() => faker.definitions.location.missing).toThrowError();
     });
   });
 
   describe('constructor()', () => {
     describe('locale', () => {
       it('should throw error if no locales passed', () => {
-        expect(() => new Faker({ locale: [] })).toThrow(
+        expect(() => new Faker({ locale: [] })).toThrowError(
           new FakerError(
             'The locale option must contain at least one locale definition.'
           )

test/faker.spec.ts

@@ -23,7 +23,7 @@ import { faker } from '../../../src';
 async function assertWorkingUrl(address: string): Promise<void> {
   expect(address).toBeTypeOf('string');
   expect(address).toMatch(/^https:\/\//);
-  expect(() => new URL(address)).not.toThrow();
+  expect(() => new URL(address)).not.toThrowError();
 
   await expect(
     new Promise((resolve, reject) => {

test/integration/modules/image.spec.ts

@@ -18,15 +18,15 @@ describe('internal', () => {
 
       const someMethodWithoutBind = someModule.someMethod;
 
-      expect(() => someMethodWithoutBind()).toThrow(
+      expect(() => someMethodWithoutBind()).toThrowError(
         new TypeError("Cannot read properties of undefined (reading 'faker')")
       );
 
       bindThisToMemberFunctions(someModule);
 
       const someMethod = someModule.someMethod;
 
-      expect(() => someMethod()).not.toThrow();
+      expect(() => someMethod()).not.toThrowError();
     });
   });
 });

test/internal/bind-this-to-member-functions.spec.ts

@@ -15,7 +15,7 @@ describe('toDate()', () => {
 
   it('should throw a FakerError for an invalid date string', () => {
     const timestamp = 'aaaa-07-05T15:49:19+0000';
-    expect(() => toDate(timestamp)).toThrow(
+    expect(() => toDate(timestamp)).toThrowError(
       new FakerError(`Invalid refDate date: ${timestamp}`)
     );
   });

test/internal/date.spec.ts

@@ -37,7 +37,7 @@ describe('LocaleProxy', () => {
       expect(() => {
         // @ts-expect-error: LocaleProxy is read-only.
         locale.category = {};
-      }).toThrow(
+      }).toThrowError(
         new FakerError('You cannot edit the locale data on the faker instance')
       );
     });
@@ -46,7 +46,7 @@ describe('LocaleProxy', () => {
       expect(() => {
         // @ts-expect-error: LocaleProxy is read-only.
         locale.airline = {};
-      }).toThrow(
+      }).toThrowError(
         new FakerError('You cannot edit the locale data on the faker instance')
       );
     });
@@ -55,7 +55,7 @@ describe('LocaleProxy', () => {
       expect(() => {
         // @ts-expect-error: LocaleProxy is read-only.
         delete locale.category;
-      }).toThrow(
+      }).toThrowError(
         new FakerError('You cannot edit the locale data on the faker instance')
       );
     });
@@ -64,7 +64,7 @@ describe('LocaleProxy', () => {
       expect(() => {
         // @ts-expect-error: LocaleProxy is read-only.
         delete locale.airline;
-      }).toThrow(
+      }).toThrowError(
         new FakerError('You cannot edit the locale data on the faker instance')
       );
     });
@@ -94,7 +94,7 @@ describe('LocaleProxy', () => {
     });
 
     it('should not be possible to access a missing entry in a missing category', () => {
-      expect(() => locale.category.missing).toThrow(
+      expect(() => locale.category.missing).toThrowError(
         new FakerError(
           `The locale data for 'category.missing' are missing in this locale.
   If this is a custom Faker instance, please make sure all required locales are used e.g. '[de_AT, de, en, base]'.
@@ -105,7 +105,7 @@ describe('LocaleProxy', () => {
     });
 
     it('should not be possible to access a missing entry in a present category', () => {
-      expect(() => locale.airline.missing).toThrow(
+      expect(() => locale.airline.missing).toThrowError(
         new FakerError(
           `The locale data for 'airline.missing' are missing in this locale.
   If this is a custom Faker instance, please make sure all required locales are used e.g. '[de_AT, de, en, base]'.
@@ -124,7 +124,7 @@ describe('LocaleProxy', () => {
         airline: { airline: null },
       });
 
-      expect(() => unavailable.airline.airline).toThrow(
+      expect(() => unavailable.airline.airline).toThrowError(
         new FakerError(
           `The locale data for 'airline.airline' aren't applicable to this locale.
   If you think this is a bug, please report it at: https://github.com/faker-js/faker`
@@ -136,7 +136,7 @@ describe('LocaleProxy', () => {
       expect(() => {
         // @ts-expect-error: LocaleProxy is read-only.
         locale.category.missing = {};
-      }).toThrow(
+      }).toThrowError(
         new FakerError('You cannot edit the locale data on the faker instance')
       );
     });
@@ -145,7 +145,7 @@ describe('LocaleProxy', () => {
       expect(() => {
         // @ts-expect-error: LocaleProxy is read-only.
         locale.airline.missing = {};
-      }).toThrow(
+      }).toThrowError(
         new FakerError('You cannot edit the locale data on the faker instance')
       );
     });
@@ -154,7 +154,7 @@ describe('LocaleProxy', () => {
       expect(() => {
         // @ts-expect-error: LocaleProxy is read-only.
         locale.airline.airline = ['dummy'];
-      }).toThrow(
+      }).toThrowError(
         new FakerError('You cannot edit the locale data on the faker instance')
       );
     });
@@ -163,7 +163,7 @@ describe('LocaleProxy', () => {
       expect(() => {
         // @ts-expect-error: LocaleProxy is read-only.
         delete locale.category.missing;
-      }).toThrow(
+      }).toThrowError(
         new FakerError('You cannot edit the locale data on the faker instance')
       );
     });
@@ -172,7 +172,7 @@ describe('LocaleProxy', () => {
       expect(() => {
         // @ts-expect-error: LocaleProxy is read-only.
         delete locale.airline.missing;
-      }).toThrow(
+      }).toThrowError(
         new FakerError('You cannot edit the locale data on the faker instance')
       );
     });
@@ -181,7 +181,7 @@ describe('LocaleProxy', () => {
       expect(() => {
         // @ts-expect-error: LocaleProxy is read-only.
         delete locale.airline.airline;
-      }).toThrow(
+      }).toThrowError(
         new FakerError('You cannot edit the locale data on the faker instance')
       );
     });

test/internal/locale-proxy.spec.ts

@@ -376,39 +376,39 @@ describe('commerce', () => {
         it('should throw FakerError when prefix contains non-digit characters', () => {
           expect(() => {
             faker.commerce.upc({ prefix: 'abc' });
-          }).toThrow('Prefix must contain only numeric digits');
+          }).toThrowError('Prefix must contain only numeric digits');
 
           expect(() => {
             faker.commerce.upc({ prefix: '123abc' });
-          }).toThrow('Prefix must contain only numeric digits');
+          }).toThrowError('Prefix must contain only numeric digits');
 
           expect(() => {
             faker.commerce.upc({ prefix: '12-34' });
-          }).toThrow('Prefix must contain only numeric digits');
+          }).toThrowError('Prefix must contain only numeric digits');
 
           expect(() => {
             faker.commerce.upc({ prefix: ' 123' });
-          }).toThrow('Prefix must contain only numeric digits');
+          }).toThrowError('Prefix must contain only numeric digits');
         });
 
         it('should throw FakerError when prefix is longer than 11 digits', () => {
           expect(() => {
             faker.commerce.upc({ prefix: '012345678901' });
-          }).toThrow('Prefix must be at most 11 numeric digits');
+          }).toThrowError('Prefix must be at most 11 numeric digits');
 
           expect(() => {
             faker.commerce.upc({ prefix: '012345678901234' });
-          }).toThrow('Prefix must be at most 11 numeric digits');
+          }).toThrowError('Prefix must be at most 11 numeric digits');
         });
 
         it('should throw FakerError with correct error message for invalid prefix types', () => {
           expect(() => {
             faker.commerce.upc({ prefix: '12a' });
-          }).toThrow('Prefix must contain only numeric digits');
+          }).toThrowError('Prefix must contain only numeric digits');
 
           expect(() => {
             faker.commerce.upc({ prefix: '012345678901' });
-          }).toThrow('Prefix must be at most 11 numeric digits');
+          }).toThrowError('Prefix must be at most 11 numeric digits');
         });
 
         it('should generate valid UPCs that pass check digit validation for multiple calls', () => {

test/modules/commerce.spec.ts

@@ -68,10 +68,12 @@ describe('datatype', () => {
           const filledOptions: { probability?: number } = Object.freeze({
             probability: 1,
           });
-          expect(() => faker.datatype.boolean(filledOptions)).not.toThrow();
+          expect(() =>
+            faker.datatype.boolean(filledOptions)
+          ).not.toThrowError();
 
           const emptyOptions: { probability?: number } = Object.freeze({});
-          expect(() => faker.datatype.boolean(emptyOptions)).not.toThrow();
+          expect(() => faker.datatype.boolean(emptyOptions)).not.toThrowError();
         });
       });
     }