Add Kurdish Kurmanji (Latin and Arabic) locale support - #3615
Add Kurdish Kurmanji (Latin and Arabic) locale support#3615mazyar-kawa02 wants to merge 1 commit into
Conversation
mazyar-kawa02
commented
Sep 22, 2025
mazyar-kawa02
commented
- Implemented person-related data including first names, last names, prefixes, and name patterns for both ku_kmr_arab and ku_kmr_latin.
- Added vehicle-related data including fuel types, manufacturers, models, and vehicle types for both ku_kmr_arab and ku_kmr_latin.
- Introduced color definitions for human colors in ku_kmr_latin.
- Created date definitions including months and weekdays for ku_kmr_latin.
- Established cell phone number formats for ku_kmr_latin.
- Developed location data including city names, building numbers, street addresses, and state names for ku_kmr_latin.
- Added lorem ipsum word definitions for ku_kmr_latin.
- Generated metadata for the Kurdish Kurmanji language in ku_kmr_latin.
- Implemented person-related data including first names, last names, prefixes, and name patterns for both ku_kmr_arab and ku_kmr_latin. - Added vehicle-related data including fuel types, manufacturers, models, and vehicle types for both ku_kmr_arab and ku_kmr_latin. - Introduced color definitions for human colors in ku_kmr_latin. - Created date definitions including months and weekdays for ku_kmr_latin. - Established cell phone number formats for ku_kmr_latin. - Developed location data including city names, building numbers, street addresses, and state names for ku_kmr_latin. - Added lorem ipsum word definitions for ku_kmr_latin. - Generated metadata for the Kurdish Kurmanji language in ku_kmr_latin.
❌ Deploy Preview for fakerjs failed.Built without sensitive environment variables
|
|
@mazyar-kawa02 Thank you for contributing to Faker. |
xDivisionByZerox
added
c: feature
|
We should probably resolve our discussion on #3441 about the most suitable language codes. We should avoid too much bikeshedding. Picking the ideal language code is important but not so important to block adding the data. |
|
Now what is needed to be done from my side? also is my PR will be merged ? |
@matthewmayer I agree with you. I'll try to get some focus onto the other PR.
@mazyar-kawa02 I was not aware of the PR mentioned by matthew. PR #3441 should probably be merged first, as it provides the foundation to the locale data sets you are trying to add. After #3441 is merged, you can update your branch and then provide PRs that add locale data. I'd suggest that I'll ping you again when the time for that has come. |
@xDivisionByZerox I reviewed PR #3441, and it only includes Kurdish Sorani. It also uses placeholder text (lorem ipsum) instead of proper first and last names. |
The other Kurdish PR has now been merged. Please refer to this comment for the approved codes to use in metadata #3441 (review) We would like to break this PR into smaller pieces to make it easier to review Can you make a new PR with just the new ku_kmr_latin locale and metadata, and one or two simple modules included (eg person and color). Once that is approved you can follow up with additional PRs for other modules and ku_kmr_arab |
Okay, I created a new PR: #3629. |
Thank you. Your efforts are greatly appreciated. 🫶 👏 |
matthewmayer
added
the
do NOT merge yet
|
#3629 was now merged! If you'd like to follow up with additional PRs for other modules for ku_kmr_latin or start a ku_kmr_arab PR now please feel free to do so! |
|
Note closing this PR for now. Please open additional PRs as needed. |
4 participants
