feat: Add support for UPC - #3648
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
please update snapshot tests using In general you can run |
I'm really sorry, I ran |
|
Just realized the CI builds were failing because I hadn’t included the snapshots in the PR. Added them now , should work fine |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #3648 +/- ##
==========================================
- Coverage 99.97% 99.97% -0.01%
==========================================
Files 2993 2994 +1
Lines 236268 236305 +37
Branches 930 940 +10
==========================================
+ Hits 236215 236248 +33
- Misses 53 57 +4
🚀 New features to boost your workflow:
|
|
CI has passed now, thanks! Just have some nitpicks on the tests. |
Shinigami92
left a comment
There was a problem hiding this comment.
Made a general review, and thanks a lot @matthewmayer for taking over the detailed review here 👍
When the points from Matt are addressed, I can give my approval ✅
…d simplify related tests
|
All changes are in. Thanks for checking it out. @matthewmayer @Shinigami92 |
xDivisionByZerox
left a comment
There was a problem hiding this comment.
Looks good. Thank you for implementing this feature. 👍
This PR fixes #3446
Have introduced support for UPC