Skip to content

test: remove flaky test in finance.spec.ts - #3651

Merged
xDivisionByZerox merged 2 commits into
faker-js:nextfrom
matthewmayer:remove-flaky-test
Nov 6, 2025
Merged

test: remove flaky test in finance.spec.ts#3651
xDivisionByZerox merged 2 commits into
faker-js:nextfrom
matthewmayer:remove-flaky-test

Conversation

@matthewmayer

Copy link
Copy Markdown
Contributor

@matthewmayer
matthewmayer requested a review from a team as a code owner November 6, 2025 12:15
@netlify

netlify Bot commented Nov 6, 2025

Copy link
Copy Markdown

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 5c89283
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/690ce3c6fc3e800008ccadae
😎 Deploy Preview https://deploy-preview-3651.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Nov 6, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.97%. Comparing base (247f42d) to head (5c89283).
⚠️ Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3651   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files        2993     2993           
  Lines      236268   236268           
  Branches      932      930    -2     
=======================================
  Hits       236215   236215           
  Misses         53       53           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xDivisionByZerox xDivisionByZerox left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for now 👍

@Shinigami92

Copy link
Copy Markdown
Member

Works for now 👍

Should we maybe just disable it conditionally on os==win?

@xDivisionByZerox
xDivisionByZerox added this pull request to the merge queue Nov 6, 2025
@xDivisionByZerox

Copy link
Copy Markdown
Member

Should we maybe just disable it conditionally on os==win?

I would leave it as is. Just fix it at some point. 🤷‍♀️

Merged via the queue into faker-js:next with commit f45077c Nov 6, 2025
23 checks passed
@ST-DDT ST-DDT added this to the v10.x milestone Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants