infra: ensure markdown rendered is only ever initialized once - #3984
Merged
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
Caches the Markdown renderer’s initialization promise to prevent concurrent duplicate initialization.
Changes:
- Adds a shared renderer promise.
- Reuses the in-flight promise across initialization calls.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3984 +/- ##
=======================================
Coverage 98.92% 98.92%
=======================================
Files 926 926
Lines 3241 3241
Branches 588 568 -20
=======================================
Hits 3206 3206
Misses 31 31
Partials 4 4 🚀 New features to boost your workflow:
|
Shinigami92
reviewed
Aug 8, 2026
Shinigami92
approved these changes
Aug 8, 2026
xDivisionByZerox
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement suggestion from shikijs/shiki#1289
Store the promise to ensure we only ever initialize the markdown rendered backend once.
This is an attempt to fix the flaky markdown rendered test.
While I don't think that it is the cause for the failure, it does fix the unintended side effects of calling
initMarkdownRenderer()multiple times.