docs: restructure DNS and WAF scope sections - #1234
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1234 +/- ##
=======================================
Coverage 98.42% 98.42%
=======================================
Files 96 96
Lines 5825 5826 +1
=======================================
+ Hits 5733 5734 +1
Misses 79 79
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
favonia
changed the title
favonia
force-pushed
the
scope-default-cleanup
branch
from
June 23, 2026 09:21
1d329d5 to
199d19d
Compare
favonia
enabled auto-merge (squash)
June 23, 2026 09:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restructure the DNS Record Scope and WAF List Scope sections: drop the meaningless
Default Valuecolumn from the scope tables, split each section into a scope table and a separate ownership-filter table, reorder so both tables precede the explanatory callouts, and document the scope-list reader contract in the readers' doc comments.readWAFListNamesnow clears its field on empty input so it matchesreadDomains. Also clarifies the WAF default prefix-length wording.