feat: canonical domain String() with root-aware Describe() - #1236
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1236 +/- ##
=======================================
Coverage 98.42% 98.42%
=======================================
Files 96 96
Lines 5826 5834 +8
=======================================
+ Hits 5734 5742 +8
Misses 79 79
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Add String() to FQDN (root → "."), update Describe() to annotate root as ". (root)", add String() to Domain interface, and add a minimal String() to Wildcard to satisfy the interface.
Match the comment to the plan's intended wording and fix a typo.
favonia
force-pushed
the
string-describe-convention
branch
from
June 24, 2026 14:47
9faf430 to
7dce83f
Compare
favonia
enabled auto-merge (squash)
June 24, 2026 14:47
Owner
Author
|
Note: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gives domain.Domain a canonical, round-trippable String() (the root domain renders as ".") and reframes Describe() as the human form that adds an annotation only where it helps (the root renders as ". (root)"), with Wildcard.Describe() equalling its String(). The domainexp.ParseList rejection path now quotes String() instead of Describe(), so rejecting DOMAINS=. reports the offending value as "." rather than an empty quote; all other human-summary Describe() callers are unchanged.