Skip to content

fix: attempt all composed reporters - #1249

Merged
favonia merged 1 commit into
mainfrom
fix-composed-reporter-short-circuit
Jul 26, 2026
Merged

fix: attempt all composed reporters#1249
favonia merged 1 commit into
mainfrom
fix-composed-reporter-short-circuit

Conversation

@favonia

@favonia favonia commented Jul 26, 2026

Copy link
Copy Markdown
Owner

A failed Healthchecks request could short-circuit heartbeat composition and prevent a later Uptime Kuma update; the same aggregation pattern also affected composed notifiers. This change evaluates every applicable child before aggregating the results, so later reporters are still attempted while the overall result continues to report any failure. Focused regressions cover Ping, Start, Exit, Log, and Send, and the full Go suite and linter pass. Fixes #1248.

@codecov

codecov Bot commented Jul 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.49%. Comparing base (ec10e81) to head (1519d12).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1249   +/-   ##
=======================================
  Coverage   98.49%   98.49%           
=======================================
  Files         100      100           
  Lines        6249     6255    +6     
=======================================
+ Hits         6155     6161    +6     
  Misses         81       81           
  Partials       13       13           
Flag Coverage Δ
smoketests 11.87% <27.27%> (-0.02%) ⬇️
unittests 98.11% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@favonia
favonia force-pushed the fix-composed-reporter-short-circuit branch from 38ef3b6 to 1519d12 Compare July 26, 2026 07:55
@favonia
favonia marked this pull request as ready for review July 26, 2026 07:55
@favonia
favonia enabled auto-merge (squash) July 26, 2026 07:56
@favonia
favonia merged commit 3dab253 into main Jul 26, 2026
35 checks passed
@favonia
favonia deleted the fix-composed-reporter-short-circuit branch July 26, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A failed Healthchecks request can prevent Uptime Kuma updates

1 participant