fix: attempt all composed reporters - #1249
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1249 +/- ##
=======================================
Coverage 98.49% 98.49%
=======================================
Files 100 100
Lines 6249 6255 +6
=======================================
+ Hits 6155 6161 +6
Misses 81 81
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
favonia
force-pushed
the
fix-composed-reporter-short-circuit
branch
from
July 26, 2026 07:55
38ef3b6 to
1519d12
Compare
favonia
marked this pull request as ready for review
July 26, 2026 07:55
favonia
enabled auto-merge (squash)
July 26, 2026 07:56
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed Healthchecks request could short-circuit heartbeat composition and prevent a later Uptime Kuma update; the same aggregation pattern also affected composed notifiers. This change evaluates every applicable child before aggregating the results, so later reporters are still attempted while the overall result continues to report any failure. Focused regressions cover
Ping,Start,Exit,Log, andSend, and the full Go suite and linter pass. Fixes #1248.