Skip to content

ux: clarify reporter delivery logs - #1250

Merged
favonia merged 6 commits into
mainfrom
notification-delivery-logs
Jul 26, 2026
Merged

ux: clarify reporter delivery logs#1250
favonia merged 6 commits into
mainfrom
notification-delivery-logs

Conversation

@favonia

@favonia favonia commented Jul 26, 2026

Copy link
Copy Markdown
Owner

Make successful Shoutrrr logs identify the notification type, and shorten Healthchecks success logs from Successfully sent ... to Sent .... Notification metadata is assigned at the command and updater boundaries, leaving remote payloads, delivery and error behavior, and quiet output unchanged. Closes #959.

@favonia
favonia force-pushed the notification-delivery-logs branch from 2798b38 to 1d15b2c Compare July 26, 2026 08:31
@favonia
favonia marked this pull request as ready for review July 26, 2026 08:31
@codecov

codecov Bot commented Jul 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.18605% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.59%. Comparing base (3dab253) to head (19aabcf).

Files with missing lines Patch % Lines
cmd/ddns/ddns.go 28.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1250      +/-   ##
==========================================
+ Coverage   98.49%   98.59%   +0.09%     
==========================================
  Files         100      102       +2     
  Lines        6255     6319      +64     
==========================================
+ Hits         6161     6230      +69     
+ Misses         81       76       -5     
  Partials       13       13              
Flag Coverage Δ
smoketests 11.84% <10.46%> (-0.03%) ⬇️
unittests 98.22% <93.02%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@favonia
favonia merged commit 5bf6fd8 into main Jul 26, 2026
34 of 35 checks passed
@favonia
favonia deleted the notification-delivery-logs branch July 26, 2026 08:49
@favonia favonia added enhancement New feature or request logging Related to what the tool outputs to the end user labels Jul 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request logging Related to what the tool outputs to the end user

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Summarize the messages sent to monitors/notifiers

1 participant