Repository navigation
Add TOU V2 cloud mapping, review fixes, docs and credits - #1
Merged
Merged
Conversation
TOU V2 timed slots over SolisCloud: - Map the verified CID family 5916-5987 into the local 43707-43791 register model: slot enable bitfield, SOC/current/voltage companions, and HH:MM-HH:MM time slots composed from HA's hour/minute registers. - Lenient time parsing (single-digit fields, whitespace); empty/unset slots decode to 00:00-00:00 instead of silently never updating. Repo review fixes: - Modbus writes now execute directly and raise HomeAssistantError on failure (write queue removed; serialization is already guaranteed by the shared per-link lock). This makes dual-mode write fallback work, surfaces write errors to entities/services, and removes the leaked queue-consumer task per protocol switch. - Sensor staleness watchdog treats poll speeds as seconds, not minutes; cloud controller reports its poll interval in seconds accordingly. - Protocol switching is serialized with a lock. - Cloud write-verify tasks are tracked and cancelled on unload. Docs: - Credit Pho3niX90/solis_modbus (fork origin), mkuthan/ solis-cloud-control and hultenvp/solis-sensor (SolisCloud references). - New protocols page; README protocol matrix and cloud limits. - Add HACS brand icon; gitignore local working notes. Tests: 264 passed (12 new). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
Failed to generate code suggestions for PR |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
5916-5987into the local43707-43791register model (slot-enable bitfield, SOC/current/voltage companions,HH:MM-HH:MMtime slots composed from HA hour/minute writes). Time parsing is lenient and unset slots decode to00:00-00:00.HomeAssistantErroron failure — dual-mode write fallback now works, and the leaked write-queue task per protocol switch is gone.Behavior note
Modbus writes no longer queue while the link is down — they fail fast and, in dual modes, fall back to the healthy protocol.
Test plan
🤖 Generated with Claude Code