Repository navigation
Conversation
infer_model_from_cloud_record now warns with the full cloud metadata when neither a textual model match nor PRODUCT_CODE_TO_MODEL resolves a model, so users can report the code and grow the table. The table itself stays a manual, community-driven expansion; there's no new data to add without a live-verified sample. Fixes #17
Contributor
|
Failed to generate code suggestions for PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue #17 asked for (1) more confirmed
PRODUCT_CODE_TO_MODELentries and (2) a lightweight mechanism to surface unrecognized product codes. (1) isn't actionable without new user-reported data; this PR implements (2):infer_model_from_cloud_record()now logs awarningwith the full cloud metadata whenever detection fails (no textual model match, no product-code match), so users can report it and grow the table.Test plan
tests/test_cloud_model_detection.py: unrecognized metadata logs the expected warning; a known product code logs nothingruff check/ruff format --checkcleanCloses #17