Repository navigation
Conversation
hassfest emits a CONFIG_SCHEMA warning because the integration defines async_setup (to register services) without declaring a config schema. The integration is config-entry only and consumes no YAML config, so declare CONFIG_SCHEMA = cv.config_entry_only_config_schema(DOMAIN). This clears the yellow hassfest annotation. Also repoint the manifest 'documentation' field from the dead solisconnect.readthedocs.io to the published GitHub Pages docs.
Contributor
|
Failed to generate code suggestions for PR |
Clears the "Node.js 20 is deprecated" runner warning that GitHub was annotating on the otherwise-green hassfest check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Validate with hassfest" workflow passes (green) but emits a prominent yellow
##[warning]that reads as a failure:The integration defines
async_setup(to register thesolis_write_holding_register/solis_write_timeservices) but declares no config schema. It's config-entry only and consumes no YAML config, so this adds:which clears the warning and formally asserts the integration takes no YAML configuration.
Also repoints the manifest
documentationfield from the deadsolisconnect.readthedocs.ioto the published GitHub Pages docs (https://fboundy.github.io/solisconnect/), matching the README fix from #34.Test plan
config_entry_only_config_schemadoesn't break config-entry setup)ruff check/ruff format --checkclean