Skip to content

This i gonna be good! - #110

Merged
fccview merged 66 commits into
developfrom
feature/missed-you-cronmaster
Oct 4, 2026
Merged

fccview merged 66 commits into
developfrom
feature/missed-you-cronmaster

Conversation

@fccview

@fccview fccview commented Oct 4, 2026 •

Copy link
Copy Markdown
Owner

Changelog

features

bugfix

  • "Create and start" no longer fails with a generic Server Components error, and failed runs say why (exit code, timeout, signal) BUG create and start new job #92
  • Logs no longer get deleted when you refresh the page on filesystems that don't record creation time (NFS, CIFS, some NAS setups) logs delete when I refresh the web gui #94
  • Logging in Docker refuses to save a job when the host data path can't be found, instead of writing a path the host can't use, and the real error now shows in the UI Enable logging set the wrong wrapper location #87
  • Cloned jobs keep their logging and get their own log folder
  • Live logs no longer show duplicated lines and no longer forget the job already finished
  • Escape now properly closes modals, so they open again afterwards
  • SSO logout actually ends the SSO session, and SSO-only users get a logout button
  • The service worker no longer returns a 500
  • DELETE /api/cronjobs/[id] works, and PATCH accepts partial updates
  • The script path preview in Docker now shows the path that actually gets written to the crontab
  • Overall system status now takes disk usage into account
  • Various minor/medium security hardening
  • Paths with spaces are quoted in new cron lines, hopefully this doesn't break anything for anyone, but spaces were basically broken to begin with.

security

  • Made sure all deps with fixes have now been addressed so yarn audit is as clean as it can possibly be
  • Node 24 upgrade in Docker and CI

fccview added 30 commits October 4, 2026 12:26
…log, oh this’ll be fun when I forget about it
fccview added 28 commits October 4, 2026 13:33
@coderabbitai

coderabbitai Bot commented Oct 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Too many files!

This PR contains 181 files, which is 31 over the limit of 150.

To get a review, reduce the PR to 150 files or fewer by splitting it into smaller PRs or changing its base branch.

Upgrade to a paid plan to raise the limit.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cfdb0ac8-53d0-45f5-a362-c8002171f13b
📥 Commits

Reviewing files that changed from the base of the PR and between 08bc59e and 7a774b7.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (181)
  • .dockerignore
  • .github/workflows/pr-checks.yml
  • .github/workflows/prebuild-release.yml
  • .gitignore
  • AGENTS.md
  • Dockerfile
  • README.md
  • app/_components/FeatureComponents/Cronjobs/CronJobList.tsx
  • app/_components/FeatureComponents/Cronjobs/Parts/CronJobEmptyState.tsx
  • app/_components/FeatureComponents/Cronjobs/Parts/CronJobItem.tsx
  • app/_components/FeatureComponents/Cronjobs/Parts/MinimalCronJobItem.tsx
  • app/_components/FeatureComponents/Cronjobs/Parts/ScriptCommandPicker.tsx
  • app/_components/FeatureComponents/Cronjobs/Parts/useJobMenuItems.tsx
  • app/_components/FeatureComponents/Cronjobs/helpers/index.tsx
  • app/_components/FeatureComponents/Games/SnakeGame.tsx
  • app/_components/FeatureComponents/Layout/AppShell.tsx
  • app/_components/FeatureComponents/Layout/Sidebar.tsx
  • app/_components/FeatureComponents/Layout/TabbedInterface.tsx
  • app/_components/FeatureComponents/LoginForm/LoginForm.tsx
  • app/_components/FeatureComponents/LoginForm/LogoutButton.tsx
  • app/_components/FeatureComponents/Modals/CloneScriptModal.tsx
  • app/_components/FeatureComponents/Modals/CloneTaskModal.tsx
  • app/_components/FeatureComponents/Modals/CreateScriptModal.tsx
  • app/_components/FeatureComponents/Modals/CreateTaskModal.tsx
  • app/_components/FeatureComponents/Modals/CronJobListsModals.tsx
  • app/_components/FeatureComponents/Modals/DeleteScriptModal.tsx
  • app/_components/FeatureComponents/Modals/DeleteTaskModal.tsx
  • app/_components/FeatureComponents/Modals/EditScriptModal.tsx
  • app/_components/FeatureComponents/Modals/EditTaskModal.tsx
  • app/_components/FeatureComponents/Modals/ErrorDetailsModal.tsx
  • app/_components/FeatureComponents/Modals/LiveLogModal.tsx
  • app/_components/FeatureComponents/Modals/LogsModal.tsx
  • app/_components/FeatureComponents/Modals/RestoreBackupModal.tsx
  • app/_components/FeatureComponents/Modals/ScriptModal.tsx
  • app/_components/FeatureComponents/Modals/SelectScriptModal.tsx
  • app/_components/FeatureComponents/PWA/PWAInstallPrompt.tsx
  • app/_components/FeatureComponents/PWA/ServiceWorkerRegister.tsx
  • app/_components/FeatureComponents/Scripts/BashEditor.tsx
  • app/_components/FeatureComponents/Scripts/BashSnippetHelper.tsx
  • app/_components/FeatureComponents/Scripts/CronExpressionHelper.tsx
  • app/_components/FeatureComponents/Scripts/ScriptsManager.tsx
  • app/_components/FeatureComponents/Scripts/catppuccin-theme.ts
  • app/_components/FeatureComponents/System/PerformanceSummary.tsx
  • app/_components/FeatureComponents/System/SystemInfo.tsx
  • app/_components/FeatureComponents/System/SystemStatus.tsx
  • app/_components/FeatureComponents/System/WrapperScriptWarning.tsx
  • app/_components/FeatureComponents/Theme/ThemeToggle.tsx
  • app/_components/FeatureComponents/User/UserFilter.tsx
  • app/_components/FeatureComponents/User/UserSwitcher.tsx
  • app/_components/GlobalComponents/Badges/ErrorBadge.tsx
  • app/_components/GlobalComponents/Badges/StatusBadge.tsx
  • app/_components/GlobalComponents/FormElements/Input.tsx
  • app/_components/GlobalComponents/UIElements/DropdownMenu.tsx
  • app/_components/GlobalComponents/UIElements/LogViewer.tsx
  • app/_components/GlobalComponents/UIElements/Modal.tsx
  • app/_components/GlobalComponents/UIElements/ProgressBar.tsx
  • app/_components/GlobalComponents/UIElements/Toast.tsx
  • app/_consts/commands.ts
  • app/_consts/file.ts
  • app/_consts/nsenter.ts
  • app/_contexts/SSEContext.tsx
  • app/_hooks/useCronJobState.ts
  • app/_hooks/useIsHydrated.ts
  • app/_hooks/useSSE.ts
  • app/_server/actions/cronjobs/index.ts
  • app/_server/actions/global/index.ts
  • app/_server/actions/logs/index.ts
  • app/_server/actions/scripts/index.ts
  • app/_server/actions/snippets/index.ts
  • app/_server/actions/translations/index.ts
  • app/_translations/be.json
  • app/_translations/de.json
  • app/_translations/en.json
  • app/_translations/fr.json
  • app/_translations/it.json
  • app/_translations/zh.json
  • app/_utils/api-auth-utils.ts
  • app/_utils/backup-utils.ts
  • app/_utils/cronjob-utils.ts
  • app/_utils/crontab-utils.ts
  • app/_utils/disk-stats-utils.ts
  • app/_utils/error-utils.ts
  • app/_utils/files-manipulation-utils.ts
  • app/_utils/format-utils.ts
  • app/_utils/global-utils.ts
  • app/_utils/job-execution-utils.ts
  • app/_utils/line-manipulation-utils.ts
  • app/_utils/live-log-utils.ts
  • app/_utils/log-files-utils.ts
  • app/_utils/log-format-utils.ts
  • app/_utils/log-watcher.ts
  • app/_utils/logger.ts
  • app/_utils/login-rate-limit.ts
  • app/_utils/oidc-utils.ts
  • app/_utils/parser-utils.ts
  • app/_utils/process-utils.ts
  • app/_utils/running-jobs-utils.ts
  • app/_utils/script-command-utils.ts
  • app/_utils/scripts-utils.ts
  • app/_utils/security-headers.ts
  • app/_utils/security-utils.ts
  • app/_utils/server-action-auth.ts
  • app/_utils/session-utils.ts
  • app/_utils/shell-utils.ts
  • app/_utils/snippets-utils.ts
  • app/_utils/sse-broadcaster.ts
  • app/_utils/sse-events.ts
  • app/_utils/static-asset-utils.ts
  • app/_utils/status-utils.ts
  • app/_utils/system-stats-utils.ts
  • app/_utils/uuid-utils.ts
  • app/_utils/wrapper-utils-client.ts
  • app/_utils/wrapper-utils.ts
  • app/api/auth/login/route.ts
  • app/api/auth/logout/route.ts
  • app/api/cronjobs/[id]/execute/route.ts
  • app/api/cronjobs/[id]/route.ts
  • app/api/cronjobs/route.ts
  • app/api/events/route.ts
  • app/api/logs/stream/route.ts
  • app/api/oidc/callback/route.ts
  • app/api/oidc/login/route.ts
  • app/api/oidc/logout/route.ts
  • app/api/scripts/route.ts
  • app/api/system-stats/route.ts
  • app/api/system/wrapper-check/route.ts
  • app/globals.css
  • app/i18n.ts
  • app/layout.tsx
  • app/not-found.tsx
  • app/page.tsx
  • app/serwist/[path]/route.ts
  • docker-compose.yml
  • eslint.config.mjs
  • howto/API.md
  • howto/DOCKER.md
  • howto/ENV_VARIABLES.md
  • howto/LOGGING.md
  • howto/LOGS.md
  • howto/SSO.md
  • instrumentation.ts
  • next.config.mjs
  • package.json
  • proxy.ts
  • test-api.mjs
  • tests/cron-line-quoting.test.ts
  • tests/cronjob-actions-scripts.test.ts
  • tests/cronjob-actions.test.ts
  • tests/cronjob-utils-crontab.test.ts
  • tests/cronjob-utils-wrapping.test.ts
  • tests/disk-stats.test.ts
  • tests/error-utils.test.ts
  • tests/format-utils.test.ts
  • tests/host-paths.test.ts
  • tests/job-execution-command.test.ts
  • tests/job-execution-errors.test.ts
  • tests/live-log-utils.test.ts
  • tests/log-exit-code.test.ts
  • tests/log-files-utils.test.ts
  • tests/log-format-utils.test.ts
  • tests/logger.test.ts
  • tests/logging-guard.test.ts
  • tests/parser-utils-locale.test.ts
  • tests/script-command-utils.test.ts
  • tests/script-files.test.ts
  • tests/script-path-preview.test.ts
  • tests/security/auth.test.ts
  • tests/security/cronjob-id-route.test.ts
  • tests/security/crontab-injection.test.ts
  • tests/security/oidc-access.test.ts
  • tests/security/path-traversal.test.ts
  • tests/security/proxy.test.ts
  • tests/security/security-utils.test.ts
  • tests/security/server-actions.test.ts
  • tests/security/session-max-age.test.ts
  • tests/security/strict-execution-user.test.ts
  • tests/shell-utils.test.ts
  • tests/system-overall-status.test.ts
  • tests/system-status.test.ts
  • tests/translations-parity.test.ts
  • vitest.config.mts

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Review on demand using usage pricing
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@fccview
fccview merged commit 0b23281 into develop Oct 4, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant