Commit f2b4ace
fix: Resolve feature view batch source name against registry
POST /api/v1/feature_views takes the batch source as a name, but the
handler turned that name into a DataSourceProto with every other field
left at its default. With `type` unset, DataSource.from_proto rejected
the spec with "Could not identify the source type being added.", so
creating a feature view from the UI always failed.
Resolve the name through the registry instead, so the feature view spec
carries the registered source's type along with its options (path,
timestamp columns, connection settings). Setting `type` alone would not
be enough: each concrete source reads its own options out of the proto,
which would persist a feature view pointing at a gutted source.
An unregistered name now raises FeastObjectNotFoundException, which both
the standalone REST registry server and the UI server already map to a
404 instead of the previous 500.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019AKoXg1p8EkTABGC46PBbw
Signed-off-by: patelchaitany <patelchaitany93@gmail.com>1 parent fa8f06b commit f2b4ace
1 file changed
Lines changed: 18 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
9 | 10 | | |
10 | 11 | | |
11 | 12 | | |
| |||
343 | 344 | | |
344 | 345 | | |
345 | 346 | | |
346 | | - | |
347 | | - | |
348 | | - | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
349 | 364 | | |
350 | 365 | | |
351 | 366 | | |
| |||
0 commit comments