feat: Bucket feature count labels in latency metrics - #6811
jingqian-liu wants to merge 3 commits into
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6811 +/- ##
==========================================
+ Coverage 47.41% 47.44% +0.02%
==========================================
Files 421 421
Lines 52249 52273 +24
Branches 7582 7587 +5
==========================================
+ Hits 24776 24801 +25
Misses 25708 25708
+ Partials 1765 1764 -1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
The macOS Python 3.12 unit-test job is still failing after the rerun. I checked the failure, and the only failing test is test_module_level_fips_sets_env_before_pyarrow_import, which times out after 60 seconds while importing feast.offline_server. All feature-server-related tests and the other Python/macOS/Linux unit-test jobs pass, so this appears unrelated to the changes in this PR. |
bac23ab to
9b57eb5
Compare
8b13f85 to
3185b9b
Compare
|
Rebased onto current master to pick up #6835, which fixes the CPU wheel hash mismatch and stabilizes the FIPS import test seen in the previous CI runs. CI is rerunning now. Thanks! |
3185b9b to
6ec94bc
Compare
|
@jingqian-liu can you please resolve conflicts ? |
Signed-off-by: Jingqian Liu <ljqstella@gmail.com>
Signed-off-by: Jingqian Liu <ljqstella@gmail.com>
Signed-off-by: Jingqian Liu <ljqstella@gmail.com>
6ec94bc to
7107102
Compare
Resolved the conflicts with current master and pushed the updated branch. Thanks! |
Hi @ntkathole, the conflicts are resolved and the branch has been rebased onto current master. Since master is moving quickly, if everything looks good after the workflows are approved, would you mind merging this when convenient? Thanks! |
What this PR does / why we need it:
The
feature_countlabel onfeast_feature_server_request_latency_secondscurrently uses the exactnumber of requested features. For workloads with widely varying feature
counts, this can create a large number of Prometheus time series and
increase metric cardinality.
This PR:
feature_countlabel values using configurable boundaries.metrics.feature_count_bins, defaulting to[10, 50, 200].0,1-10,11-50,51-200, and201+.0as a separate label for zero-feature requests.metric label is bucketed.
increasing.
For example: