fix: Resolve feature view batch source name against registry - #6849
Open
patelchaitany wants to merge 1 commit into
Open
patelchaitany wants to merge 1 commit into
patelchaitany wants to merge 1 commit into
Conversation
POST /api/v1/feature_views takes the batch source as a name, but the handler turned that name into a DataSourceProto with every other field left at its default. With `type` unset, DataSource.from_proto rejected the spec with "Could not identify the source type being added.", so creating a feature view from the UI always failed. Resolve the name through the registry instead, so the feature view spec carries the registered source's type along with its options (path, timestamp columns, connection settings). Setting `type` alone would not be enough: each concrete source reads its own options out of the proto, which would persist a feature view pointing at a gutted source. An unregistered name now raises FeastObjectNotFoundException, which both the standalone REST registry server and the UI server already map to a 404 instead of the previous 500. Signed-off-by: Chaitany Patel <patelchaitany93@gmail.com>
patelchaitany
force-pushed
the
fix/rest-apply-feature-view-batch-source
branch
from
September 18, 2026 11:54
f2b4ace to
ceb4059
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6849 +/- ##
==========================================
- Coverage 47.43% 47.43% -0.01%
==========================================
Files 422 422
Lines 52263 52266 +3
Branches 7582 7583 +1
==========================================
Hits 24791 24791
- Misses 25708 25709 +1
- Partials 1764 1766 +2
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/v1/feature_viewsreceives the batch source as a name, but the handler built aDataSourceProtofrom just that name, leavingtypeand all other fields at their default.DataSource.from_protothen rejected it with "Could not identify the source type being added.", surfacing as a 500 from the UI.GetDataSource) instead, so the feature view spec carries the registered source's actual type along with its options (path, timestamp columns, connection settings). An unregistered name now raisesFeastObjectNotFoundException, which the REST registry server and UI server already map to a 404.Test plan
uv run bash -c "cd sdk/python && mypy feast/api/registry/rest/feature_views.py"uv run ruff check sdk/python/feast/api/registry/rest/feature_views.pyfeast init && feast apply && feast ui, then create a feature view from the UI and confirm it succeeds.