fix: retain categories for archived streaming data

Author: lopezm1

fbclient/streaming.py

@@ -59,12 +59,16 @@ def _data_to_dict(data: dict) -> Tuple[int, dict]:
         flag['_id'] = flag['id']
         flag['id'] = flag['key']
         flag['cat'] = FEATURE_FLAGS
-        flags[flag['id']] = {'id': flag['id'], 'timestamp': flag['timestamp'], 'isArchived': True} if flag['isArchived'] else flag
+        flags[flag['id']] = ({'id': flag['id'], 'timestamp': flag['timestamp'],
+                             'isArchived': True, 'cat': FEATURE_FLAGS}
+                            if flag['isArchived'] else flag)
         version = max(version, flag['timestamp'])
     for segment in data['segments']:
         segment['timestamp'] = from_str_datetime_to_millis(segment['updatedAt'])
         segment['cat'] = SEGMENTS
-        segments[segment['id']] = {'id': segment['id'], 'timestamp': segment['timestamp'], 'isArchived': True} if segment['isArchived'] else segment
+        segments[segment['id']] = ({'id': segment['id'], 'timestamp': segment['timestamp'],
+                                   'isArchived': True, 'cat': SEGMENTS}
+                                  if segment['isArchived'] else segment)
         version = max(version, segment['timestamp'])
     return version, all_data
 

tests/test_runtime_safety.py

@@ -13,7 +13,8 @@
 from fbclient.notice_broadcaster import NoticeBroadcater
 from fbclient.status import DataUpdateStatusProviderImpl
 from fbclient.status_types import State, StateType
-from fbclient.streaming import Streaming
+from fbclient.streaming import Streaming, _data_to_dict
+from fbclient.category import FEATURE_FLAGS, SEGMENTS
 import fbclient.streaming as streaming_module
 from fbclient.update_processor import NullUpdateProcessor
 from fbclient.utils.http_client import build_http_factory
@@ -99,6 +100,26 @@ def close(self, **_kwargs):
     streaming.stop()
 
 
+def test_archived_streaming_data_retains_category_for_broadcast():
+    _, data = _data_to_dict({
+        "featureFlags": [{
+            "id": "archived-flag-id",
+            "key": "archived-flag",
+            "updatedAt": "2026-01-01T00:00:00Z",
+            "variations": [],
+            "isArchived": True,
+        }],
+        "segments": [{
+            "id": "archived-segment-id",
+            "updatedAt": "2026-01-01T00:00:00Z",
+            "isArchived": True,
+        }],
+    })
+
+    assert data[FEATURE_FLAGS]["archived-flag"]["cat"] == FEATURE_FLAGS
+    assert data[SEGMENTS]["archived-segment-id"]["cat"] == SEGMENTS
+
+
 def test_notice_broadcaster_is_safe_during_listener_churn():
     broadcaster = NoticeBroadcater()
     callback_count = [0]