Skip to content

fix: warn that copied ecash is spendable #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FrankChinedu wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: warn that copied ecash is spendable #560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3259bbf
fix: warn that copied ecash is spendable
FrankChinedu Aug 17, 2026
b70f6f5
fix: raise contrast of the ecash clipboard warning
FrankChinedu Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 32 additions & 1 deletion lib/ecash_send.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ class _EcashSendState extends State<EcashSend> {
// redeems it first owns it, so it must not reach a screenshot, a screen
// recording, or the app-switcher thumbnail.
return SecureScreen(
child: Padding(
child: SingleChildScrollView(
padding: const EdgeInsets.all(20),
child: Column(
mainAxisSize: MainAxisSize.min,
Expand Down Expand Up @@ -344,6 +344,37 @@ class _EcashSendState extends State<EcashSend> {
},
),
const SizedBox(height: 24),
// The token below is a bearer instrument, and the copy button hands
// it to a clipboard that other apps, input methods and sync services
// can read. State that plainly next to the control rather than after
// the fact, so the user knows before they tap.
Container(
padding: const EdgeInsets.all(12),
decoration: BoxDecoration(
color: Colors.orange.shade100,
borderRadius: BorderRadius.circular(8),
),
child: Row(
crossAxisAlignment: CrossAxisAlignment.start,
children: [
// Foreground is brown.shade900 rather than an orange: on this
// orange.shade100 background `Colors.orange` gives a contrast
// ratio of 1.7:1, far below the 4.5:1 WCAG AA needs for body
// text, and a warning nobody can comfortably read defeats the
// point. Darker oranges are not enough either — shade900 only
// reaches 3.0:1 — whereas this keeps the warm tone at 10.9:1.
Icon(Icons.warning, color: Colors.brown.shade900, size: 20),
const SizedBox(width: 8),
Expanded(
child: Text(
context.l10n.ecashClipboardWarning,
style: TextStyle(color: Colors.brown.shade900),
),
),
],
),
),
const SizedBox(height: 12),
Container(
padding: const EdgeInsets.symmetric(horizontal: 16, vertical: 14),
decoration: BoxDecoration(
Expand Down
3 changes: 3 additions & 0 deletions lib/l10n/app_en.arb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1321,6 +1321,9 @@
"ecashCopiedToClipboard": "Ecash copied to clipboard",
"@ecashCopiedToClipboard": {},

"ecashClipboardWarning": "Anyone who reads this token can spend it. Other apps can read your clipboard, so only paste it where you intend to send the funds.",
"@ecashClipboardWarning": {},

"federationLabel": "Federation",
"@federationLabel": {},

Expand Down
1 change: 1 addition & 0 deletions lib/l10n/app_es.arb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,7 @@
"failedToLoadEcash": "Error al cargar Ecash",
"ecashWithdrawn": "Ecash retirado",
"ecashCopiedToClipboard": "Ecash copiado al portapapeles",
"ecashClipboardWarning": "Cualquiera que lea este token puede gastarlo. Otras aplicaciones pueden leer tu portapapeles, así que pégalo solo donde quieras enviar los fondos.",
"federationLabel": "Federación",
"confirmPayment": "Confirmar pago",
"amountSpent": "{amount} gastado",
Expand Down
Loading