fix: use WASM-safe mint recovery timeout - #9056
Open
fedimint-bot wants to merge 1 commit into
Open
Conversation
elsirion
reviewed
Aug 26, 2026
| paths: | ||
| include: | ||
| - modules/fedimint-mint-client/ | ||
| - modules/fedimint-mintv2-client/ |
Contributor
There was a problem hiding this comment.
@fedimint-bot should includ all client and common modules. amend
Contributor
Author
There was a problem hiding this comment.
Amended in 35fe8c0.
Changed ban-tokio-timeout to include:
modules/fedimint-*-client/modules/fedimint-*-common/
Verified with:
just formatsemgrep --config .config/semgrep.yaml --include 'modules/fedimint-*-client/**' --include 'modules/fedimint-*-common/**' --error --quiet
The amend commit hook also ran the configured pre-commit checks.
fedimint-bot
force-pushed
the
fedimint-bot/wasm-timeout-9054
branch
from
August 26, 2026 13:43
60def0a to
35fe8c0
Compare
elsirion
marked this pull request as ready for review
August 31, 2026 16:22
elsirion
enabled auto-merge
August 31, 2026 16:22
elsirion
approved these changes
Aug 31, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 31, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 3, 2026
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9054.
Summary
Replace mint recovery's direct
tokio::time::timeoutcalls withfedimint_core::runtime::timeout, which works in WASM builds.Details
tokio::time::timeoutusage in the affected mint client crates.Testing
just formatcargo check -q -p fedimint-mint-clientcargo check -q -p fedimint-mintv2-clientgit commit