Skip to content

chore: remove Name_IPNISync from PingHealthFuncs - #1482

Open
beck-8 wants to merge 1 commit into
mainfrom
chore/remove-ipni-from-ping
Open

chore: remove Name_IPNISync from PingHealthFuncs#1482
beck-8 wants to merge 1 commit into
mainfrom
chore/remove-ipni-from-ping

Conversation

@beck-8

@beck-8 beck-8 commented Aug 31, 2026

Copy link
Copy Markdown
Member

No description provided.

@beck-8
beck-8 requested review from a team and ZenGround0 as code owners August 31, 2026 05:20
@FilOzzy FilOzzy added this to FOC Aug 31, 2026
@github-project-automation github-project-automation Bot moved this to 📌 Triage in FOC Aug 31, 2026
@FilOzzy FilOzzy moved this from 📌 Triage to 🔎 Awaiting review in FOC Aug 31, 2026

@LexLuthr LexLuthr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we dropping IPNI from health check?

@github-project-automation github-project-automation Bot moved this from 🔎 Awaiting review to ⌨️ In Progress in FOC Aug 31, 2026
@beck-8

beck-8 commented Sep 1, 2026

Copy link
Copy Markdown
Member Author

@LexLuthr
Given that cid.contact fixed the cache problem yesterday. So I can say it here now.

if ipni is slow or has a cache problem, it will cause all SP pdp/ping 503, which is similar to an attack. So remove this part of the check from /pdp/ping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants