Skip to content

chore: remove Name_IPNISync from PingHealthFuncs #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
beck-8 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −13
Open

chore: remove Name_IPNISync from PingHealthFuncs #1482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion alertmanager/alert_maps.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,5 @@ func buildPingHealthFuncs() map[AlertName]AlertFunc {
Name_ChainSync: af[Name_ChainSync],
Name_PermanentStorageSpace: af[Name_PermanentStorageSpace],
Name_PDPTaskFailures: af[Name_PDPTaskFailures],
Name_IPNISync: af[Name_IPNISync],
}
}
15 changes: 3 additions & 12 deletions alertmanager/task_alert.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,18 +206,9 @@ func (a *AlertTask) Do(ctx context.Context, taskID harmonytask.TaskID, stillOwne
if !ok || out == nil || (out.err == nil && out.alertString == "") {
continue
}
// Only say unhealthy if PDP IPNI sync is failing, PoRep provider should not fail health check
if name == Name_IPNISync {
if strings.Contains(out.alertString, "PDP") {
log.Warnf("Ping health check problem: %s %v %s", name, out.err, out.alertString)
detail = fmt.Sprintf("%s: %v %s", name, out.err, out.alertString)
break
}
} else {
log.Warnf("Ping health check problem: %s %v %s", name, out.err, out.alertString)
detail = fmt.Sprintf("%s: %v %s", name, out.err, out.alertString)
break
}
log.Warnf("Ping health check problem: %s %v %s", name, out.err, out.alertString)
detail = fmt.Sprintf("%s: %v %s", name, out.err, out.alertString)
break
}
a.pingMu.Lock()
a.pingProblemDetail = detail
Expand Down
Loading