Skip to content

Commit 307f035

Browse files
soodokuclaude
andcommitted
Follow the snake_case rename outside the test tree
CI's inline "Test CLI and MCP protocol" step and the IDE-integration setup script both read `.isError` off a CallToolResult. mcp 2.x renamed model fields to snake_case, so both needed `.is_error`. My earlier sweep only covered tests/ and rmcp/, which is why CI caught these and I did not. Deliberately unchanged: scripts/testing/test-local.sh and scripts/test-claude-connector.py also mention isError/structuredContent, but those index raw JSON-RPC response dicts, where camelCase is the wire format and still correct. Verified by running CI's script verbatim against a real stdio server. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent 41f25eb commit 307f035

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -474,7 +474,7 @@ jobs:
474474
"summary_stats",
475475
{"data": {"x": [1, 2, 3, 4, 5]}, "variables": ["x"]},
476476
)
477-
assert not result.isError, result.content
477+
assert not result.is_error, result.content
478478
print(f"MCP stdio OK: {len(names)} tools, summary_stats ran")
479479
480480

scripts/setup/ide_integrations.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,7 @@ async def run_analysis():
352352
except Exception as e:
353353
pytest.fail(f"Sample analysis failed: {e}")
354354

355-
assert not result.isError, f"Sample analysis returned error: {result.content}"
355+
assert not result.is_error, f"Sample analysis returned error: {result.content}"
356356
print("Sample analysis successful")
357357

358358

0 commit comments

Comments
 (0)