Skip to content

Commit 43e1449

Browse files
author
linux_name2
committed
fix: suppress SC2034 for library vars, fix integration test exit code 143
1 parent 08e8119 commit 43e1449

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ jobs:
6060
steps:
6161
- uses: actions/checkout@v6
6262
- run: |
63-
shellcheck -s bash -e SC1090,SC1091,SC2010 \
63+
shellcheck -s bash -e SC1090,SC1091,SC2010,SC2034 \
6464
bin/atomic-upgrade \
6565
bin/atomic-gc \
6666
bin/atomic-rebuild-uki \

‎tests/test_integration.sh‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ section() { echo ""; echo "── $1 ──"; }
4646
# ── Setup ─────────────────────────────────────────────────────
4747

4848
TESTDIR=$(mktemp -d)
49-
trap 'rm -rf "$TESTDIR"; kill 0 2>/dev/null' EXIT
49+
trap 'rm -rf "$TESTDIR"' EXIT
5050

5151
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
5252
PROJECT_ROOT="$(cd "$SCRIPT_DIR/.." && pwd)"
@@ -227,7 +227,8 @@ run_cmd env ATOMIC_UPGRADE=1 CONFIG_FILE="${CONF_DIR}/guard_on.conf" \
227227
LOCK_FILE="$TEST_LOCK" bash "$GUARD"
228228
assert_eq "ATOMIC_UPGRADE + lock held → exit 0" "0" "$_rc"
229229

230-
kill $LOCK_PID 2>/dev/null; wait $LOCK_PID 2>/dev/null
230+
kill $LOCK_PID 2>/dev/null
231+
wait $LOCK_PID 2>/dev/null || true
231232

232233

233234
section "guard: ATOMIC_UPGRADE + lock file missing → fail"

0 commit comments

Comments
 (0)