refactor: replace indexOf(...) === -1 checks with Array.includes

Author: mbaumgartl

lib/config-parser.js

@@ -129,7 +129,7 @@ function parseMap(map, context) {
  * @private
  */
 function checkWhitelist(str, whitelist, context) {
-    if (whitelist.indexOf(str) === -1) {
+    if (!whitelist.includes(str)) {
         throw new ImplementationError(
             'Invalid "' + str + '" (allowed: ' + whitelist.join(', ') + ')' + context.errorContext
         );

lib/request-resolver.js

@@ -400,7 +400,7 @@ function processRequestOptions(req, attrNode, context) {
                         ].join('')
                     );
                 }
-                if (filteredAttrNode.filter.indexOf(filter.operator) === -1) {
+                if (!filteredAttrNode.filter.includes(filter.operator)) {
                     throw new RequestError(
                         [
                             'Can not filter by attribute "' + filter.attribute.join('.') + '" ',
@@ -437,7 +437,7 @@ function processRequestOptions(req, attrNode, context) {
                         );
                     }
 
-                    if (subFilter.filter.indexOf(filter.operator) === -1) {
+                    if (!subFilter.filter.includes(filter.operator)) {
                         throw new RequestError(
                             `Can not filter by sub-resource attribute "${filter.attribute.join('.')}"` +
                                 (context.attrPath.length > 0 ? ` (in "${context.attrPath.join('.')}")` : '') +
@@ -608,7 +608,7 @@ function processRequestOptions(req, attrNode, context) {
                     ].join('')
                 );
             }
-            if (orderedAttrNode.order.indexOf(orderPart.direction) === -1) {
+            if (!orderedAttrNode.order.includes(orderPart.direction)) {
                 throw new RequestError(
                     [
                         'Attribute "' + orderPart.attribute.join('.') + '" ',
@@ -1027,7 +1027,7 @@ function resolveResourceTree(resourceTree, parentDataSourceName) {
             let selectedDataSource = primaryName;
             const possibleDataSources = Object.keys(attrInfo.subResourceAttrNode.resolvedParentKey);
 
-            if (possibleDataSources.indexOf(selectedDataSource) === -1) {
+            if (!possibleDataSources.includes(selectedDataSource)) {
                 // just select first possible one - optimize?
                 selectedDataSource = possibleDataSources[0];
                 attrInfo.subResourceAttrNode.parentDataSource = selectedDataSource;