Generalise locating configuration files in 'settings' - #1086
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generalises the
locate_settings_filefunction in thesettingsmodule, so that it can operate with arbitrary config file names, search one or more environment variables specified by the calling subprogram, and use a custom search path also specified by the calling subprogram.When the function is used from within the
Settingsclass to search for theauto_process.inifile, then the name, the environment variable (AUTO_PROCESS_CONF) and search path (current directory,configdirectory and installation directory) are now provided expliciting within that class (rather than implicitly within thelocate_settings_filefunction).This update will allow the
locate_settings_filefunction to be reused in other packages. It should also provide some additional flexibility if needed in future.