Update organism name normalisation function and apply more consistently - #1184
Merged
Merged
Conversation
Update the 'normalise_organism_name' to convert all non-alphanumeric characters to underscores.
Explicitly call the 'normalise_organism_name' function to get a normalised name, for consistency with other code in the package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two updates:
normalise_organism_namein theutilsmodule, to also remove non-alphanumeric characters (so e.g.C. elegans->c_elegans)normalise_organism_namefunction in the QC pipeline so that normalisation is applied more consistently within theauto-processpackage.