chunk: ensure to close the Tempfile for decompressed data - #5480
Merged
Conversation
Tempfile is not used with a block in GzipDecompressable#open and ZstdDecompressable#open, so it has to be closed explicitly, but no such close existed. The temporary file was therefore left undeleted. Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Watson1978
force-pushed
the
close-decompress-tempfile
branch
from
September 1, 2026 07:36
8e1a7da to
9f66490
Compare
kenhys
approved these changes
Sep 2, 2026
Watson1978
added
the
backport to v1.19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
GzipDecompressable#openandZstdDecompressable#opencreate aTempfilewithout a block, so it has to be closed explicitly, but no such close existed. The temporary file was therefore left undeleted.Docs Changes:
N/A
Release Note: