feat: add CommitClient.Get to resolve HEAD for a branch or tag - #327
Open
amarkdotdev wants to merge 1 commit into
Open
feat: add CommitClient.Get to resolve HEAD for a branch or tag#327amarkdotdev wants to merge 1 commit into
amarkdotdev wants to merge 1 commit into
Conversation
Add Get(ctx, ref) across providers so callers can resolve a commit SHA for a branch/tag without listing recent commits first. Fixes fluxcd#84 Signed-off-by: amarkdotdev <amarkdotdev@users.noreply.github.com>
Author
|
Friendly bump on this one. CI is green on my side and it's been sitting a few weeks with no review yet. Happy to adjust if priorities shifted or if there's anything I can do to help move it forward. Thanks! |
Member
|
@amarkdotdev If you're talking about priorities taking #84 into consideration, yes, priorities have shifted. That issue is from 5 years ago. If you are really using these libraries and need the feature for a specific reason, that's another story. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CommitClient.Get(ctx, ref)to resolve a commit for a branch, tag, or SHA without listing commits firstGetCommit), Gitea, and Stash (with list fallback where needed)GetmatchesListPageHEADFixes #84
Test plan
go test ./github/ ./gitlab/ ./gitea/ ./stash/(non-e2e)make test-e2e-github/make test-e2e-gitlabwith tokens