feat(github): give GitHubClient both a sync and an async call form

Wraps the 25 client methods with flyte's @Syncify, matching how the SDK
itself exposes Run.listall, flyte.run and flyte.serve. Each method now has
two forms: `client.foo(...)` blocks, `await client.foo.aio(...)` does not.

- Adds __enter__/__exit__ so the blocking form is actually usable. They run
  __aenter__/__aexit__ on syncify's background loop -- the same loop the
  syncified methods run on -- so the httpx.AsyncClient is created and used
  on a single loop.
- Internal self-calls use .aio(). The blocking form would deadlock when
  called from syncify's own loop thread.
- The MCP tool bridge uses .aio(). `await getattr(client, name)(...)` would
  otherwise raise TypeError on the returned value, and would stall the MCP
  server's event loop for the duration of every tool call.
- Tests, examples and READMEs use .aio() on async paths, and document both
  forms plus when not to reach for the blocking one.

The syncified client type-checks clean: mypy resolves methods to
SyncFunction[...] and the error count on the package is unchanged.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VKZrTNjjWVzTZUxDFbn4Nk

Author: cosmicBboy

plugins/github/README.md

@@ -45,14 +45,32 @@ from flyteplugins.github import GitHubClient
 @env.task
 async def summarize_pr(repo: str, number: int) -> str:
     async with GitHubClient() as client:
-        pr = await client.get_pull_request(repo, number)
-        files = await client.get_pull_request_files(repo, number)
+        pr = await client.get_pull_request.aio(repo, number)
+        files = await client.get_pull_request_files.aio(repo, number)
     return f"{pr['title']}: {len(files)} files changed"
 ```
 
 The client covers repositories, files, commits, issues, pull requests,
 reviews, branches, check runs, and merging — see `flyteplugins.github.GitHubClient`.
 
+### Both call forms
+
+Every client method is available two ways. `await client.get_pull_request.aio(...)` is the
+async form — use it in `async def` tasks and anywhere on an app's event loop.
+`client.get_pull_request(...)` is the blocking form, for plain `def` tasks and scripts:
+
+```python
+@env.task
+def summarize(...) -> str:
+    with GitHubClient() as client:          # note: `with`, not `async with`
+        pr = client.get_pull_request(repo, number)
+    ...
+```
+
+The blocking form parks the calling thread until the call returns, so never
+reach for it inside an `async def` task or a webhook handler — it would stall
+the event loop and everything else waiting on it.
+
 ## Human review gate (condition with a JSON payload)
 
 `review_pr` parks a run on a `flyte.new_condition` whose markdown prompt
@@ -69,7 +87,7 @@ async def gated_merge(repo: str, number: int) -> str:
     if not decision.is_approved:
         return f"blocked: {decision.summary}"
     async with GitHubClient() as client:
-        await client.merge_pull_request(repo, number, merge_method="squash")
+        await client.merge_pull_request.aio(repo, number, merge_method="squash")
     return "merged"
 ```
 

plugins/github/examples/pr_review_gate.py

@@ -37,15 +37,15 @@ async def gated_merge(repo: str, number: int) -> str:
     if not decision.is_approved:
         # Post the reviewer's feedback back to the PR before bailing out.
         async with GitHubClient() as client:
-            await client.create_issue_comment(
+            await client.create_issue_comment.aio(
                 repo,
                 number,
                 f"Review gate blocked this merge: {decision.summary}",
             )
         return f"blocked: {decision.summary}"
 
     async with GitHubClient() as client:
-        result = await client.merge_pull_request(repo, number, merge_method="squash")
+        result = await client.merge_pull_request.aio(repo, number, merge_method="squash")
     return f"merged {result.get('sha', '')}"
 
 

plugins/github/examples/react_to_pr_events.py

@@ -71,7 +71,7 @@ async def label_new_issues(event):
     if event.repository is None or event.number is None:
         return None
     async with GitHubClient() as client:
-        await client.add_labels(event.repository, event.number, ["flyte-triage"])
+        await client.add_labels.aio(event.repository, event.number, ["flyte-triage"])
     return {"labeled": event.number}
 
 

plugins/github/examples/read_write_pr.py

@@ -32,8 +32,8 @@
 async def summarize_pr(repo: str, number: int) -> str:
     """Read a pull request and summarize what it changes."""
     async with GitHubClient() as client:
-        pr = await client.get_pull_request(repo, number)
-        files = await client.get_pull_request_files(repo, number)
+        pr = await client.get_pull_request.aio(repo, number)
+        files = await client.get_pull_request_files.aio(repo, number)
     summary = "\n".join(f"- {f['filename']} (+{f['additions']}/-{f['deletions']})" for f in files[:20])
     return f"{pr['title']} ({pr['head']} -> {pr['base']})\n{summary}"
 
@@ -45,9 +45,9 @@ async def triage_pr(repo: str, number: int) -> str:
     This is the task the webhook example launches for every newly opened PR.
     """
     async with GitHubClient() as client:
-        pr = await client.get_pull_request(repo, number)
-        await client.add_labels(repo, number, ["flyte-triage"])
-        await client.create_issue_comment(
+        pr = await client.get_pull_request.aio(repo, number)
+        await client.add_labels.aio(repo, number, ["flyte-triage"])
+        await client.create_issue_comment.aio(
             repo,
             number,
             f"Flyte triage: this PR touches {pr.get('changed_files', '?')} files "
@@ -56,7 +56,7 @@ async def triage_pr(repo: str, number: int) -> str:
 
         head_sha = pr.get("head_sha")
         if head_sha:
-            await client.create_check_run(
+            await client.create_check_run.aio(
                 repo,
                 name="flyte-triage",
                 head_sha=head_sha,

plugins/github/src/flyteplugins/github/__init__.py

@@ -25,11 +25,16 @@
 @env.task
 async def summarize_pr(repo: str, number: int) -> str:
     async with GitHubClient() as client:
-        pr = await client.get_pull_request(repo, number)
-        files = await client.get_pull_request_files(repo, number)
+        pr = await client.get_pull_request.aio(repo, number)
+        files = await client.get_pull_request_files.aio(repo, number)
     return f"{pr['title']}: {len(files)} files changed"
 ```
 
+Every client method has two call forms: `await client.get_pull_request.aio(...)` for
+async tasks and app handlers, and `client.get_pull_request(...)` (under a plain `with`)
+for sync tasks and scripts. The blocking form stalls the calling thread, so never
+use it on an event loop.
+
 ## Human review gate (condition with a JSON payload)
 
 ```python
@@ -40,7 +45,7 @@ async def gated_merge(repo: str, number: int) -> str:
     decision = await review_pr(repo, number)
     if decision.is_approved:
         async with GitHubClient() as client:
-            await client.merge_pull_request(repo, number, merge_method="squash")
+            await client.merge_pull_request.aio(repo, number, merge_method="squash")
         return "merged"
     return f"blocked: {decision.summary}"
 ```