artifacts: parent lineage, duck-typed declaration protocol, content-hash versions - #1527
Open
EngHabu wants to merge 3 commits into
Open
artifacts: parent lineage, duck-typed declaration protocol, content-hash versions#1527EngHabu wants to merge 3 commits into
EngHabu wants to merge 3 commits into
Conversation
EngHabu
force-pushed
the
haytham/volume-artifacts-core
branch
2 times, most recently
from
September 3, 2026 20:15
37cae94 to
bdf15eb
Compare
…ash versions - Metadata gains parents (ordered ArtifactParent | bare-version entries, serialized to the new repeated parent_artifacts on both ProducedArtifact and ArtifactSpec) and version_from_content (opt-in: an empty version resolves to the literal's content hash at conversion/create time, making republish of identical content idempotent). - Output conversion duck-types get_flyte_metadata() on top-level outputs so offloaded-asset types outside flyte.io (e.g. plugin volumes) can declare themselves; a new current_output_declares_artifact contextvar tells the value's transformer when a declaration is actually being emitted. - ensure_artifactable and Artifact.create accept protocol-carrying values; create() gains parents= and seeds defaults from duck metadata like it does from the wrapper. - flyteidl2 pinned to 2.0.48 (repeated parent_artifacts), incl. rs_controller. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N415hnSCNmZ2e7WrwEPJo7 Signed-off-by: Haytham Abuelfutuh <haytham@union.ai>
EngHabu
force-pushed
the
haytham/volume-artifacts-core
branch
from
September 3, 2026 20:21
bdf15eb to
1a4ef4a
Compare
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N415hnSCNmZ2e7WrwEPJo7 Signed-off-by: Haytham Abuelfutuh <haytham@union.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core plumbing so plugin-provided offloaded assets (Union Volumes first) can publish as artifacts, and so any artifact can carry git-style parent lineage. Pairs with unionai/flyteplugins-union (volume wiring) and rides flyteidl2 2.0.48's
repeated parent_artifacts(flyteorg/flyte#7972).What changed
Metadata.parents— ordered parent edges (ArtifactParentor a bare version string = same-name parent), serialized ontoProducedArtifact.parent_artifacts(declarative path) viato_produced_artifact. A bare entry stays keyless on the wire so the service inherits the child's name/scope;ArtifactParentcarries a key only when overriding.Metadata.version_from_content— opt-in: an empty version resolves to the literal's content hash (Literal.hash) at conversion/create time, so republishing identical content is idempotent. Opt-in on purpose: File/Dir defaults are unchanged.get_flyte_metadata() -> Metadata | None, not justArtifactWrapper. A newcurrent_output_declares_artifact()contextvar (set only for the output actually being declared, never for nested values) lets the value's transformer stamp registry knowledge into the serialized value.Artifact.create(parents=...)— imperative path parity: fillsArtifactSpec.parent_artifacts; duck metadata seeds name/version/description/attrs/card/parents exactly like the wrapper does;ensure_artifactableaccepts protocol-carrying values.rs_controllerpyproject/Cargo pins + lock checksums).Testing
tests/flyte/test_produces_artifacts.py: parent serialization shapes, ordered multi-parents, duck-typed declaration + contextvar behavior, content-hash version precedence (explicit > hash > empty).tests/flyte/remote/test_artifact.py:create(parents=...)wire shapes, duck seeding, hash-defaulted versions.🤖 Generated with Claude Code
https://claude.ai/code/session_01N415hnSCNmZ2e7WrwEPJo7