Skip to content

Commit 35b1e47

Browse files
EngHabuclaude
andcommitted
core: make the ArtifactKey uniqueness doc precise
Copilot review feedback: name the actual identity tuple instead of the old 'project and domain and suffix needs to be unique' sentence. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015JKranYEJG44SPwfPFqWnk Signed-off-by: Haytham Abuelfutuh <haytham@union.ai>
1 parent 95a181c commit 35b1e47

5 files changed

Lines changed: 6085 additions & 6079 deletions

File tree

flyteidl2/core/artifact_id.proto

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,10 @@ import "google/protobuf/timestamp.proto";
88
option go_package = "github.com/flyteorg/flyte/v2/gen/go/flyteidl2/core";
99

1010
message ArtifactKey {
11-
// Project and domain and suffix needs to be unique across a given artifact store.
12-
// Length bounds match artifact.ArtifactName; fields stay optional because an
13-
// empty field means "inherit from context" in several uses (e.g.
11+
// Identifies one artifact within an artifact store: the (org, project,
12+
// domain, name) tuple must be unique. Length bounds match
13+
// artifact.ArtifactName; fields stay optional because an empty field means
14+
// "inherit from context" in several uses (e.g.
1415
// artifact.ArtifactSpec.parent_artifacts).
1516
string project = 1 [(buf.validate.field).string.max_len = 64];
1617
string domain = 2 [(buf.validate.field).string.max_len = 64];

gen/go/flyteidl2/core/artifact_id.pb.go

Lines changed: 4 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/go/gateway/flyteidl2/connector/service.swagger.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)