Merge configuration.inline storage overrides into co-pilot's Secret

configuration.inline reaches the binary as 100-inline-config.yaml, which viper
merges over the chart's 003-storage.yaml. Co-pilot never sees that file, and
once a Secret is configured nothing travels on its command line either, so a
deployment that set its endpoint or session token through inline had co-pilot
talking to a different object store than the binary it belongs to.

Merge the same overrides into the Secret. The block the helper already renders
is round-tripped through fromYaml so the provider branching stays in one
place, and only deployments that actually set configuration.inline.storage
take that path: every other render is byte-identical.

Verified that the result loads under co-pilot's strict-mode config accessor,
including the devbox's storage.signedURL section, which the merge now carries
across.

Signed-off-by: Kevin Su <pingsutw@apache.org>

Author: pingsutw

charts/flyte-binary/templates/config-secret.yaml

@@ -78,6 +78,18 @@ stringData:
   # The whole Secret is projected, so the key name is ours to choose — but the .yaml suffix
   # is what makes co-pilot's *.yaml glob find it, and an unsuffixed key is never read.
   copilot-storage-config.yaml: |
-    {{- include "flyte-binary.configuration.storageBlock" (dict "root" $ "withCredentials" true) | nindent 4 }}
+    {{- $block := include "flyte-binary.configuration.storageBlock" (dict "root" $ "withCredentials" true) }}
+    {{- $inlineStorage := dict }}
+    {{- if and .Values.configuration.inline (hasKey .Values.configuration.inline "storage") }}
+    {{- $inlineStorage = index .Values.configuration.inline "storage" }}
+    {{- end }}
+    {{- if $inlineStorage }}
+    {{- /* configuration.inline reaches the binary through 100-inline-config.yaml, which
+           co-pilot never sees. Merge the same overrides in here, or co-pilot talks to a
+           different object store than the deployment it belongs to. */}}
+    {{- toYaml (mergeOverwrite ($block | fromYaml) (dict "storage" $inlineStorage)) | nindent 4 }}
+    {{- else }}
+    {{- $block | nindent 4 }}
+    {{- end }}
 {{- end }}
 {{- end }}

docker/devbox-bundled/manifests/complete.yaml

@@ -8187,18 +8187,21 @@ metadata:
 stringData:
   copilot-storage-config.yaml: |
     storage:
-      type: stow
+      container: flyte-data
+      signedURL:
+        stowConfigOverride:
+          endpoint: http://localhost:30002
       stow:
-        kind: s3
         config:
-          region: us-east-1
+          access_key_id: rustfs
+          auth_type: accesskey
           disable_ssl: true
-          v2_signing: true
           endpoint: http://rustfs-svc.flyte:9000
-          auth_type: accesskey
-          access_key_id: "rustfs"
-          secret_key: "rustfsstorage"
-      container: flyte-data
+          region: us-east-1
+          secret_key: rustfsstorage
+          v2_signing: true
+        kind: s3
+      type: stow
 type: Opaque
 ---
 apiVersion: v1
@@ -8761,7 +8764,7 @@ spec:
     metadata:
       annotations:
         checksum/configuration: 234f623bb88a11f8007d57f08b191c0d071273e46a56b910dfbba8ae6f43a34c
-        checksum/configuration-secret: 652a905205b043cbc7e2d4dbb41c05679fbec92bd4aecee1b996834f797d559b
+        checksum/configuration-secret: ff95a9986cc42dff0a114449c9b8e9a95c781b7bdd9832b31ca461423ae0b678
       labels:
         app.kubernetes.io/component: flyte-binary
         app.kubernetes.io/instance: flyte-devbox