Skip to content

[V2] feat: Dockerfile for each components - #7238

Closed
lowc1012 wants to merge 29 commits into
flyteorg:v2from
lowc1012:flyte-7203-dockfile-with-bake
Closed

[V2] feat: Dockerfile for each components#7238
lowc1012 wants to merge 29 commits into
flyteorg:v2from
lowc1012:flyte-7203-dockfile-with-bake

Conversation

@lowc1012

@lowc1012 lowc1012 commented Apr 19, 2026

Copy link
Copy Markdown
Contributor

Tracking issue

Related to Flyte v2 (#7203)

Why are the changes needed?

  1. Create Dockerfile for each v2 components
  2. Use Buildx Bake to manage monorepo Docker builds and build them in parallel

What changes were proposed in this pull request?

How was this patch tested?

Labels

Please add one or more of the following labels to categorize your PR:

  • added: For new features.
  • changed: For changes in existing functionality.
  • deprecated: For soon-to-be-removed features.
  • removed: For features being removed.
  • fixed: For any bug fixed.
  • security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Ryan Lo <wenchih@apache.org>
@lowc1012
lowc1012 force-pushed the flyte-7203-dockfile-with-bake branch from 1b2d65e to 1f82f1e Compare April 19, 2026 08:08
lowc1012 added 16 commits April 19, 2026 21:16
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
@lowc1012
lowc1012 marked this pull request as ready for review April 19, 2026 16:22
@lowc1012

Copy link
Copy Markdown
Contributor Author

@popojk Please take a look this PR, thanks

Signed-off-by: Ryan Lo <wenchih@apache.org>

@popojk popojk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lowc1012 , thanks for your contribution! I just left a few comments. BTW, could you also check:

  1. I don't see the dockerfile for secret service in the PR. Would you mind add one?
  2. I don't see helm charts changes in this PR. Are you gonna do it in another PR?

Comment thread .github/workflows/flyte-binary-v2.yml Outdated
Comment thread .github/workflows/flyte-core-v2.yaml
Comment thread docker/docker-bake.hcl Outdated
Comment thread docker/Dockerfile.actions Outdated
Comment thread docker/Dockerfile.runs Outdated
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>

@popojk popojk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good except 1 small issue then we are good to go. @pingsutw Would you mind also take a look at this?

Comment thread .github/workflows/flyte-core-v2.yaml
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>

@pingsutw pingsutw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of building ARM and AMD images in separate jobs, could we build a multi-arch image in a single job. like

platforms: linux/arm64, linux/amd64
tags: ${{ steps.gpu-image-names.outputs.tags }}
build-args: |
FLYTE_DEVBOX_VERSION=${{ env.FLYTE_DEVBOX_VERSION }}
BASE_IMAGE=base
push: ${{ github.event_name == 'push' || github.event_name == 'workflow_dispatch' }}

@pingsutw pingsutw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a dockerfile for the app service too

Comment thread .github/workflows/flyte-core-v2.yaml Outdated
Comment thread docker/Dockerfile.actions Outdated

@pingsutw pingsutw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we just merged the v2 branch into main, could you update the base branch to main?

Comment thread .github/workflows/git_town.yml
@lowc1012

lowc1012 commented May 1, 2026

Copy link
Copy Markdown
Contributor Author

Could we add a dockerfile for the app service too

@pingsutw, curious about how to start the AppService?

lowc1012 added 4 commits May 1, 2026 14:01
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
@lowc1012 lowc1012 closed this May 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants