[V2] feat: Dockerfile for each components - #7238
Conversation
Signed-off-by: Ryan Lo <wenchih@apache.org>
1b2d65e to
1f82f1e
Compare
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
|
@popojk Please take a look this PR, thanks |
Signed-off-by: Ryan Lo <wenchih@apache.org>
popojk
left a comment
There was a problem hiding this comment.
Hey @lowc1012 , thanks for your contribution! I just left a few comments. BTW, could you also check:
- I don't see the dockerfile for secret service in the PR. Would you mind add one?
- I don't see helm charts changes in this PR. Are you gonna do it in another PR?
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
There was a problem hiding this comment.
Instead of building ARM and AMD images in separate jobs, could we build a multi-arch image in a single job. like
flyte/.github/workflows/flyte-binary-v2.yml
Lines 220 to 225 in 38fb221
pingsutw
left a comment
There was a problem hiding this comment.
Could we add a dockerfile for the app service too
pingsutw
left a comment
There was a problem hiding this comment.
Also, we just merged the v2 branch into main, could you update the base branch to main?
@pingsutw, curious about how to start the AppService? |
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Tracking issue
Related to Flyte v2 (#7203)
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
main