Skip to content

Upgrade to Go 1.27 - #7949

Open
Sovietaced wants to merge 1 commit into
flyteorg:mainfrom
Sovietaced:go-1.27
Open

Upgrade to Go 1.27#7949
Sovietaced wants to merge 1 commit into
flyteorg:mainfrom
Sovietaced:go-1.27

Conversation

@Sovietaced

@Sovietaced Sovietaced commented Sep 1, 2026

Copy link
Copy Markdown
Member

Why are the changes needed?

New versions of Go include new features, performance improvements, and security fixes. See: https://go.dev/doc/go1.27

What changes were proposed in this pull request?

Leveraged Go 1.27 to do the following

  1. Converted futures, auto-refresh cache, and scheduler timing tests to testing/synctest.
  2. Migrated service-client HTTP tests to Go 1.27’s in-memory httptest.NewTestServer.
  3. Modernized reverse event traversal with slices.Backward.
  4. Ran the atomictypes, slicesbackward, and unsafefuncs fixers. Only the reverse-loop change was safely applicable.

How was this patch tested?

Labels

Please add one or more of the following labels to categorize your PR:

  • added: For new features.
  • changed: For changes in existing functionality.
  • deprecated: For soon-to-be-removed features.
  • removed: For features being removed.
  • fixed: For any bug fixed.
  • security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Stack

If you do use git town to manage PR Stacks, the stack relevant to this PR
will show below. Otherwise, you can ignore this section.

Docs link

@github-actions github-actions Bot added the flyte2 label Sep 1, 2026
@Sovietaced Sovietaced added the dependencies Pull requests that update a dependency file label Sep 1, 2026
Signed-off-by: Jason Parraga <sovietaced@gmail.com>
)

func TestAzureTemplateLogPlugin(t *testing.T) {
type args struct {

@Sovietaced Sovietaced Sep 2, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go 1.27 changed the compress/flate implementation, so gzip output can produce different—but equally valid—compressed bytes.
The Azure test previously asserted the entire generated URL, including a hard-coded base64-encoded gzip payload. After upgrading Go, that byte-for-byte value changed even though the decompressed Azure query was identical.
I changed this to verify the meaningful behavior:

  1. Check the Azure URL prefix and log metadata.
  2. URL-decode the query.
  3. Base64-decode it.
  4. Gzip-decompress it.
  5. Compare the resulting query text with the expected query.
    So it was a test-stability adjustment required by Go 1.27’s compression change, not a production behavior change. It also avoids future failures when compression output changes without changing its contents.

@Sovietaced
Sovietaced marked this pull request as ready for review September 2, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file flyte2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant