test(breadcrumbs): distinguish workflow identity from launch plan

Identical project and domain values let the self-link test pass even when it read the launch-plan identifier. Separate every identity so the route assertion covers project and domain as well as the workflow name.

Signed-off-by: 1fanwang <1fannnw@gmail.com>

Author: 1fanwang

packages/oss-console/src/components/Breadcrumbs/async/executionContext.ts

@@ -50,22 +50,16 @@ const getExecutionData = async (projectId: string, domainId: string, executionId
 };
 
 const isExecutionTaskOrWorkflow = (executionData: Execution) => {
-  // Check the resourceType of the actual executed entity (workflowId),
-  // not the launch plan identifier
   return executionData.closure.workflowId.resourceType === ResourceType.TASK
     ? ResourceType.TASK
     : ResourceType.WORKFLOW;
 };
 
 const getTaskOrWorkflowName = (executionData: Execution): string => {
-  // Return the actual workflow/task name from closure.workflowId,
-  // not the launch plan name from spec.launchPlan
   return executionData.closure.workflowId.name;
 };
 
 const getTaskOrWorkflowVersion = (executionData: Execution): string => {
-  // Return the actual workflow/task version from closure.workflowId,
-  // not the launch plan version from spec.launchPlan
   return executionData.closure.workflowId.version;
 };
 
@@ -132,7 +126,6 @@ export const executonTaskWorkFlowNameAsyncSelfLink: BreadcrumbEntitySelfLinkAsyn
   const resourceName = getTaskOrWorkflowName(executionData);
   const resourceType = isExecutionTaskOrWorkflow(executionData);
 
-  // Use closure.workflowId (the actual workflow) instead of spec.launchPlan
   const { project: desinationProject, domain: desinationDomain } = getExecutionSpecProjectDomain(
     executionData.closure.workflowId,
     breadcrumb,
@@ -160,7 +153,6 @@ export const executionTaskWorkflowVersions: BreadcrumbAsyncPopOverData = async (
   const entityResourceName = getTaskOrWorkflowName(executionData);
   const entityResourceVersion = getTaskOrWorkflowVersion(executionData);
 
-  // Use closure.workflowId (the actual workflow) instead of spec.launchPlan
   const { project: desinationProject, domain: desinationDomain } = getExecutionSpecProjectDomain(
     executionData.closure.workflowId,
     breadcrumb,
@@ -348,7 +340,6 @@ export const executionTaskWorkflowViewAll: BreadcrumbAsyncViewAllLink = async (
   const executionType = isExecutionTaskOrWorkflow(executionData);
   const entityResourceName = getTaskOrWorkflowName(executionData);
 
-  // Use closure.workflowId (the actual workflow) instead of spec.launchPlan
   const { project: desinationProject, domain: desinationDomain } = getExecutionSpecProjectDomain(
     executionData.closure.workflowId,
     breadcrumb,

packages/oss-console/src/components/Breadcrumbs/async/tests/executionContext.test.ts

@@ -1,66 +1,61 @@
 import Core from '@clients/common/flyteidl/core';
 import { Execution } from '../../../../models/Execution/types';
+import {
+  executonTaskWorkFlowNameAsyncValue,
+  executonTaskWorkFlowNameAsyncSelfLink,
+  executonNamedEntityAsyncValue,
+} from '../executionContext';
 
-// Mock the SimpleCacheCallbackManager
 jest.mock('@clients/primitives/SimpleCache/SimpleCacheCallbackManager', () => ({
   SimpleCacheCallbackManager: jest.fn().mockImplementation(() => ({
     getCachedOrFetch: jest.fn((_key: string, fn: () => Promise<Execution>) => fn()),
   })),
 }));
 
-// Mock the execution API
 const mockGetExecution = jest.fn();
 jest.mock('../../../../models/Execution/api', () => ({
   getExecution: (...args: unknown[]) => mockGetExecution(...args),
   listExecutions: jest.fn(),
 }));
 
-// Mock the routes
 jest.mock('../../../../routes/routes', () => ({
   Routes: {
     WorkflowDetails: {
-      makeUrl: jest.fn((project: string, domain: string, name: string) =>
-        `/projects/${project}/domains/${domain}/workflows/${name}`),
+      makeUrl: jest.fn(
+        (project: string, domain: string, name: string) =>
+          `/projects/${project}/domains/${domain}/workflows/${name}`,
+      ),
     },
     TaskDetails: {
-      makeUrl: jest.fn((project: string, domain: string, name: string) =>
-        `/projects/${project}/domains/${domain}/tasks/${name}`),
+      makeUrl: jest.fn(
+        (project: string, domain: string, name: string) =>
+          `/projects/${project}/domains/${domain}/tasks/${name}`,
+      ),
     },
     ExecutionDetails: {
-      makeUrl: jest.fn(({ project, domain, name }: { project: string; domain: string; name: string }) =>
-        `/projects/${project}/domains/${domain}/executions/${name}`),
+      makeUrl: jest.fn(
+        ({ project, domain, name }: { project: string; domain: string; name: string }) =>
+          `/projects/${project}/domains/${domain}/executions/${name}`,
+      ),
     },
     EntityVersionDetails: {
       makeUrl: jest.fn(),
     },
   },
 }));
 
-// Import after mocking
-import {
-  executonTaskWorkFlowNameAsyncValue,
-  executonTaskWorkFlowNameAsyncSelfLink,
-  executonNamedEntityAsyncValue,
-} from '../executionContext';
-
-/**
- * Creates a mock execution where the launch plan name differs from the workflow name.
- * This simulates the bug scenario where:
- * - Launch plan name: 'hello_world_lp'
- * - Actual workflow name: 'hello_world_wf'
- */
 const createMockExecutionWithDifferentNames = (): Execution => ({
   id: {
-    project: 'flytesnacks',
-    domain: 'development',
+    project: 'execution-project',
+    domain: 'execution-domain',
     name: 'wf-execution-001',
   },
   spec: {
     launchPlan: {
       resourceType: Core.ResourceType.LAUNCH_PLAN,
-      project: 'flytesnacks',
-      domain: 'development',
-      name: 'hello_world_lp', // Launch plan name
+      project: 'launch-plan-project',
+      domain: 'launch-plan-domain',
+      name: 'hello_world_lp',
       version: '2025-04-09-15-56-08',
     },
     inputs: { literals: {} },
@@ -74,20 +69,17 @@ const createMockExecutionWithDifferentNames = (): Execution => ({
   closure: {
     workflowId: {
       resourceType: Core.ResourceType.WORKFLOW,
-      project: 'flytesnacks',
-      domain: 'development',
-      name: 'hello_world_wf', // Actual workflow name (different!)
+      project: 'workflow-project',
+      domain: 'workflow-domain',
+      name: 'hello_world_wf',
       version: '2025-04-09-15-56-08',
     },
-    phase: 4, // ABORTED
+    phase: 4,
     createdAt: { seconds: { low: 1732000000, high: 0, unsigned: false }, nanos: 0 },
     startedAt: { seconds: { low: 1732000000, high: 0, unsigned: false }, nanos: 0 },
   },
 });
 
-/**
- * Creates a mock execution for a task (not a workflow)
- */
 const createMockTaskExecution = (): Execution => ({
   id: {
     project: 'test-project',
@@ -118,16 +110,16 @@ const createMockTaskExecution = (): Execution => ({
       name: 'my-actual-task',
       version: 'v1',
     },
-    phase: 3, // SUCCEEDED
+    phase: 3,
     createdAt: { seconds: { low: 1732000000, high: 0, unsigned: false }, nanos: 0 },
     startedAt: { seconds: { low: 1732000000, high: 0, unsigned: false }, nanos: 0 },
   },
 });
 
 describe('executionContext breadcrumb functions', () => {
   const mockBreadcrumb = {
-    projectId: 'flytesnacks',
-    domainId: 'development',
+    projectId: 'workflow-domain',
+    domainId: 'browsing-domain',
     value: '',
     defaultValue: () => '',
   };
@@ -147,9 +139,7 @@ describe('executionContext breadcrumb functions', () => {
 
       const result = await executonTaskWorkFlowNameAsyncValue(mockLocation, mockBreadcrumb as any);
 
-      // Should return the WORKFLOW name, not the launch plan name
       expect(result).toBe('hello_world_wf');
-      // Should NOT return the launch plan name
       expect(result).not.toBe('hello_world_lp');
     });
 
@@ -211,12 +201,14 @@ describe('executionContext breadcrumb functions', () => {
         pathname: '/projects/flytesnacks/domains/development/executions/wf-execution-001',
       } as Location;
 
-      const result = await executonTaskWorkFlowNameAsyncSelfLink(mockLocation, mockBreadcrumb as any);
+      const result = await executonTaskWorkFlowNameAsyncSelfLink(
+        mockLocation,
+        mockBreadcrumb as any,
+      );
 
-      // Should link to the workflow details page with the WORKFLOW name
-      expect(result).toContain('hello_world_wf');
-      expect(result).toContain('/workflows/');
-      // Should NOT contain the launch plan name
+      expect(result).toBe(
+        '/projects/workflow-project/domains/workflow-domain/workflows/hello_world_wf',
+      );
       expect(result).not.toContain('hello_world_lp');
     });
 
@@ -238,44 +230,4 @@ describe('executionContext breadcrumb functions', () => {
       expect(result).not.toContain('my-task-launch-plan');
     });
   });
-
-  describe('Bug scenario: Launch plan name differs from workflow name', () => {
-    /**
-     * This test verifies the fix for the bug where:
-     * 1. User is on Launch Plan page showing 'hello_world_lp'
-     * 2. User clicks into an execution
-     * 3. Breadcrumb should show the WORKFLOW name 'hello_world_wf'
-     * 4. NOT the launch plan name 'hello_world_lp'
-     *
-     * Before the fix, clicking the breadcrumb would navigate to:
-     *   /workflows/hello_world_lp (empty page - wrong!)
-     *
-     * After the fix, clicking the breadcrumb navigates to:
-     *   /workflows/hello_world_wf (correct workflow page)
-     */
-    it('should use workflow name in breadcrumb, not launch plan name', async () => {
-      const mockExecution = createMockExecutionWithDifferentNames();
-      mockGetExecution.mockResolvedValue(mockExecution);
-
-      const mockLocation = {
-        pathname: '/projects/flytesnacks/domains/development/executions/wf-execution-001',
-      } as Location;
-
-      // Get the workflow/task name shown in breadcrumb
-      const breadcrumbName = await executonTaskWorkFlowNameAsyncValue(mockLocation, mockBreadcrumb as any);
-
-      // Get the self-link URL when clicking the breadcrumb
-      const selfLinkUrl = await executonTaskWorkFlowNameAsyncSelfLink(mockLocation, mockBreadcrumb as any);
-
-      // Verify the breadcrumb shows the correct workflow name
-      expect(breadcrumbName).toBe('hello_world_wf');
-
-      // Verify clicking the breadcrumb navigates to the correct workflow page
-      expect(selfLinkUrl).toBe('/projects/flytesnacks/domains/development/workflows/hello_world_wf');
-
-      // Verify we're NOT using the launch plan name
-      expect(breadcrumbName).not.toBe('hello_world_lp');
-      expect(selfLinkUrl).not.toContain('hello_world_lp');
-    });
-  });
 });