Skip to content

fix(breadcrumbs): link executions to the workflow that ran - #921

Open
1fanwang wants to merge 2 commits into
flyteorg:masterfrom
1fanwang:fix-breadcrumb-uses-executed-workflow
Open

fix(breadcrumbs): link executions to the workflow that ran#921
1fanwang wants to merge 2 commits into
flyteorg:masterfrom
1fanwang:fix-breadcrumb-uses-executed-workflow

Conversation

@1fanwang

@1fanwang 1fanwang commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

TL;DR

An execution launched through a differently named launch plan links its breadcrumb to
a workflow that does not exist.

Before this change, a launch plan named hello_world_lp for workflow
hello_world_wf shows and links the launch-plan name. After this change, the breadcrumb
shows and links the workflow that actually ran.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added. Not applicable: no public API changed.
  • Any pending items have an associated Issue. No pending items.

Complete description

Build the breadcrumb from the executed workflow identity instead of the launch-plan
identity. The label becomes "Workflow Name."

Manual check:

  1. Register launch plan hello_world_lp for workflow hello_world_wf.
  2. Launch it and open the execution page.
  3. Click the "Workflow Name" breadcrumb.

Before this change, the breadcrumb shows hello_world_lp and opens an empty workflow
page. With this change, it shows hello_world_wf and opens that workflow. Regression
tests cover workflow and task executions.

The focused domain correction from #939
is now on master. The regression separates execution, launch-plan, workflow, and
browsing identities so the final URL proves every route field comes from the executed
workflow.

Tracking Issue

N/A

Follow-up issue

N/A

@1fanwang 1fanwang changed the title fix(breadcrumbs): link to the executed workflow, not the launch plan fix(breadcrumbs): link executions to the workflow that ran Aug 20, 2026
@1fanwang
1fanwang force-pushed the fix-breadcrumb-uses-executed-workflow branch from 2f51a4a to 240301a Compare August 24, 2026 10:06
The execution breadcrumb read its self-link, name, version, project, and domain from the launch-plan identifier. When a launch plan name differed from its workflow name, the breadcrumb pointed at a workflow page that did not exist. Read the identity from the executed workflow and relabel the breadcrumb as Workflow Name.

Signed-off-by: 1fanwang <1fannnw@gmail.com>
Identical project and domain values let the self-link test pass even when it read the launch-plan identifier. Separate every identity so the route assertion covers project and domain as well as the workflow name.

Signed-off-by: 1fanwang <1fannnw@gmail.com>
@1fanwang
1fanwang force-pushed the fix-breadcrumb-uses-executed-workflow branch from 240301a to c8ac8f0 Compare August 24, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant