fix(breadcrumbs): link executions to the workflow that ran - #921
Open
1fanwang wants to merge 2 commits into
Open
fix(breadcrumbs): link executions to the workflow that ran#9211fanwang wants to merge 2 commits into
1fanwang wants to merge 2 commits into
Conversation
8 tasks
1fanwang
force-pushed
the
fix-breadcrumb-uses-executed-workflow
branch
from
August 24, 2026 10:06
2f51a4a to
240301a
Compare
The execution breadcrumb read its self-link, name, version, project, and domain from the launch-plan identifier. When a launch plan name differed from its workflow name, the breadcrumb pointed at a workflow page that did not exist. Read the identity from the executed workflow and relabel the breadcrumb as Workflow Name. Signed-off-by: 1fanwang <1fannnw@gmail.com>
Identical project and domain values let the self-link test pass even when it read the launch-plan identifier. Separate every identity so the route assertion covers project and domain as well as the workflow name. Signed-off-by: 1fanwang <1fannnw@gmail.com>
1fanwang
force-pushed
the
fix-breadcrumb-uses-executed-workflow
branch
from
August 24, 2026 10:28
240301a to
c8ac8f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
An execution launched through a differently named launch plan links its breadcrumb to
a workflow that does not exist.
Before this change, a launch plan named
hello_world_lpfor workflowhello_world_wfshows and links the launch-plan name. After this change, the breadcrumbshows and links the workflow that actually ran.
Type
Are all requirements met?
Complete description
Build the breadcrumb from the executed workflow identity instead of the launch-plan
identity. The label becomes "Workflow Name."
Manual check:
hello_world_lpfor workflowhello_world_wf.Before this change, the breadcrumb shows
hello_world_lpand opens an empty workflowpage. With this change, it shows
hello_world_wfand opens that workflow. Regressiontests cover workflow and task executions.
The focused domain correction from #939
is now on master. The regression separates execution, launch-plan, workflow, and
browsing identities so the final URL proves every route field comes from the executed
workflow.
Tracking Issue
N/A
Follow-up issue
N/A