Skip to content

Commit c13abeb

Browse files
committed
Fix some typos
Signed-off-by: Barry Wu <a0987818905@gmail.com>
1 parent edd9c8d commit c13abeb

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

tests/flytekit/unit/core/test_type_engine.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3888,8 +3888,8 @@ def test_type_engine_cache():
38883888
# Verify different literals are different objects
38893889
assert literal1 is not literal3
38903890

3891-
# Test cache with unhashable objects (should not cache)
3892-
python_val = {"a": [1, 2, 3]} # dict with list is unhashable
3891+
# Test cache with unhashable objects
3892+
python_val = {"a": [1, 2, 3]}
38933893
python_type = typing.Dict[str, typing.List[int]]
38943894
expected = TypeEngine.to_literal_type(python_type)
38953895

@@ -3902,7 +3902,7 @@ def test_type_engine_cache():
39023902
# Second call with same unhashable data
39033903
literal5 = TypeEngine.to_literal(ctx, python_val, python_type, expected)
39043904

3905-
# Should be different objects since unhashable objects can't be cached
3905+
# Should be the same object since unhashable objects will fallback to cloudpickle to hash
39063906
assert literal4 is literal5
39073907

39083908
# Add many different values to test cache size limit

0 commit comments

Comments
 (0)