Skip to content

[BUG] ImageSpec NoOpBuilder should always return True while calling should_build function - #3311

Merged
pingsutw merged 4 commits into
flyteorg:masterfrom
popojk:ImageSpec-NoOpBuilder-should-always-return-True-while-calling-should_build-function
Aug 16, 2025
Merged

[BUG] ImageSpec NoOpBuilder should always return True while calling should_build function#3311
pingsutw merged 4 commits into
flyteorg:masterfrom
popojk:ImageSpec-NoOpBuilder-should-always-return-True-while-calling-should_build-function

fix: refactor doc string and test

a2919cb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 16, 2025 in 1s

92.51% (+7.25%) compared to eb5a67f

View this Pull Request on Codecov

92.51% (+7.25%) compared to eb5a67f

Details

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.51%. Comparing base (eb5a67f) to head (a2919cb).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3311      +/-   ##
==========================================
+ Coverage   85.26%   92.51%   +7.25%     
==========================================
  Files         386        7     -379     
  Lines       30276      508   -29768     
  Branches     2969        0    -2969     
==========================================
- Hits        25814      470   -25344     
+ Misses       3615       38    -3577     
+ Partials      847        0     -847     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.