Skip to content

Dynamic platform detection for ImageSpec to support cross-platform development #3315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pingsutw merged 4 commits into from
Aug 27, 2025
Merged

Dynamic platform detection for ImageSpec to support cross-platform development #3315

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
38ecf5c
Dynamic platform detection for ImageSpec to support cross-platform de…
BarryWu0812 Aug 15, 2025
052706b
Change platform to ARM64 if platform is not set and pushing to local …
BarryWu0812 Aug 17, 2025
81e8df7
Add Optional for type checking
BarryWu0812 Aug 18, 2025
068c872
Fix lint
BarryWu0812 Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions flytekit/image_spec/image_spec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import hashlib
import os
import pathlib
import platform
import re
import sys
import typing
Expand Down Expand Up @@ -48,7 +49,7 @@ class ImageSpec:
cuda (Optional[str]): Version of cuda to install.
cudnn (Optional[str]): Version of cudnn to install.
base_image (Optional[Union[str, 'ImageSpec']]): Base image of the image.
platform (str): Specify the target platforms for the build output (for example, windows/amd64 or linux/amd64,darwin/arm64).
platform (Optional[str]): Specify the target platforms for the build output (for example, windows/amd64 or linux/amd64,darwin/arm64).
pip_index (Optional[str]): Specify the custom pip index url.
pip_extra_index_url (Optional[List[str]]): Specify one or more pip index urls as a list.
pip_secret_mounts (Optional[List[Tuple[str, str]]]): Specify a list of tuples to mount secret for pip install. Each tuple should contain the path to
Expand Down Expand Up @@ -94,7 +95,7 @@ class ImageSpec:
cuda: Optional[str] = None
cudnn: Optional[str] = None
base_image: Optional[Union[str, "ImageSpec"]] = None
platform: str = "linux/amd64"
Comment thread
pingsutw marked this conversation as resolved.
platform: Optional[str] = None
pip_index: Optional[str] = None
pip_extra_index_url: Optional[List[str]] = None
pip_secret_mounts: Optional[List[Tuple[str, str]]] = None
Expand Down Expand Up @@ -126,6 +127,17 @@ def __post_init__(self):
f"- 'docker.io/username' (for docker hub)\n"
)

if self.platform is None:
if (
self.registry
and self.registry.lower().startswith("localhost:")
Comment thread
machichima marked this conversation as resolved.
and platform.machine().lower() in ("arm64", "aarch64")
):
# Only change platform to ARM64 if platform is not set and pushing to local registry on ARM64 machine
self.platform = "linux/arm64"
else:
self.platform = "linux/amd64"

# If not set, help the user set this option as well, to support the older default behavior where existence
# of the source root implied that copying of files was needed.
if self.source_root is not None:
Expand Down
Loading