Skip to content

Fix flytekit-greatexpectations tests: replace dead ge_tutorials CSV URL #3461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pingsutw merged 2 commits into from
Aug 18, 2026
Merged

Fix flytekit-greatexpectations tests: replace dead ge_tutorials CSV URL #3461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92eaea5
Fix greatexpectations tests: replace dead ge_tutorials CSV URL
pingsutw Aug 18, 2026
4a47ae2
Merge branch 'master' into fix-ge-remote-csv-url
pingsutw Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/flytekit-greatexpectations/tests/test_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ def my_wf(dataset: CSVFile) -> int:
return my_task(dataset=dataset)

result = my_wf(
dataset="https://raw.githubusercontent.com/superconductive/ge_tutorials/main/data/yellow_tripdata_sample_2019-01.csv"
dataset="https://raw.githubusercontent.com/flyteorg/flytekit/master/plugins/flytekit-greatexpectations/tests/data/yellow_tripdata_sample_2019-01.csv"
)
assert result == 10000

Expand All @@ -313,7 +313,7 @@ def my_task(dataset: GreatExpectationsType[CSVFile, ge_config]) -> int:
@workflow
def my_wf() -> int:
return my_task(
dataset="https://raw.githubusercontent.com/superconductive/ge_tutorials/main/data/yellow_tripdata_sample_2019-01.csv"
dataset="https://raw.githubusercontent.com/flyteorg/flytekit/master/plugins/flytekit-greatexpectations/tests/data/yellow_tripdata_sample_2019-01.csv"
)

result = my_wf()
Expand Down
10 changes: 5 additions & 5 deletions plugins/flytekit-greatexpectations/tests/test_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ def test_ge_remote_flytefile():
)

task_object(
dataset="https://raw.githubusercontent.com/superconductive/ge_tutorials/main/data/yellow_tripdata_sample_2019-01.csv"
dataset="https://raw.githubusercontent.com/flyteorg/flytekit/master/plugins/flytekit-greatexpectations/tests/data/yellow_tripdata_sample_2019-01.csv"
)


Expand All @@ -229,7 +229,7 @@ def my_wf(dataset: CSVFile) -> int:
return my_task(dataset=dataset)

result = my_wf(
dataset="https://raw.githubusercontent.com/superconductive/ge_tutorials/main/data/yellow_tripdata_sample_2019-01.csv"
dataset="https://raw.githubusercontent.com/flyteorg/flytekit/master/plugins/flytekit-greatexpectations/tests/data/yellow_tripdata_sample_2019-01.csv"
)
assert result == 10000

Expand All @@ -246,7 +246,7 @@ def test_ge_remote_flytefile_workflow():

@workflow
def valid_wf(
dataset: CSVFile = "https://raw.githubusercontent.com/superconductive/ge_tutorials/main/data/yellow_tripdata_sample_2019-01.csv",
dataset: CSVFile = "https://raw.githubusercontent.com/flyteorg/flytekit/master/plugins/flytekit-greatexpectations/tests/data/yellow_tripdata_sample_2019-01.csv",
) -> None:
task_object(dataset=dataset)

Expand Down Expand Up @@ -298,8 +298,8 @@ def get_file_name(dataset_one: FlyteFile, dataset_two: FlyteFile) -> typing.Tupl

@workflow
def wf(
dataset_one: FlyteFile = "https://raw.githubusercontent.com/superconductive/ge_tutorials/main/data/yellow_tripdata_sample_2019-01.csv",
dataset_two: FlyteFile = "https://raw.githubusercontent.com/superconductive/ge_tutorials/main/data/yellow_tripdata_sample_2019-02.csv",
dataset_one: FlyteFile = "https://raw.githubusercontent.com/flyteorg/flytekit/master/plugins/flytekit-greatexpectations/tests/data/yellow_tripdata_sample_2019-01.csv",
dataset_two: FlyteFile = "https://raw.githubusercontent.com/flyteorg/flytekit/master/plugins/flytekit-greatexpectations/tests/data/yellow_tripdata_sample_2019-02.csv",
) -> typing.Tuple[int, int]:
task_object_one(dataset=dataset_one)
task_object_two(dataset=dataset_two)
Expand Down
Loading