Repository navigation
Drop the runtime setuptools pin - #3476
Merged
Merged
Conversation
marshmallow-jsonschema 0.14.0 replaced pkg_resources with importlib.metadata, so flytekit no longer needs setuptools at runtime. Assisted-by: Claude Code <noreply@anthropic.com> Signed-off-by: Sergey Vilgelm <sergey@union.ai>
SVilgelm
requested review from
cosmicbboy,
davidmirror-ops,
kumare3,
machichima,
pingsutw,
samhita-alla and
wild-endeavor
as code owners
October 22, 2026 16:15
ydata-profiling 4.18.4 still imports pkg_resources and doesn't declare setuptools. Assisted-by: Claude Code <noreply@anthropic.com> Signed-off-by: Sergey Vilgelm <sergey@union.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
flytekit has listed
setuptools<82as a runtime dependency since #3388. That pin only providedpkg_resources, which marshmallow-jsonschema 0.13 and older import on load. Downstream environments that install flytekit are then stuck on setuptools 81 or older, and those versions carry CVE-2026-59890 / GHSA-h35f-9h28-mq5c (fixed in setuptools 83).marshmallow-jsonschema 0.14.0 switched to
importlib.metadata, so the pin is no longer needed.What changes were proposed in this pull request?
marshmallow-jsonschema>=0.14.0.setuptools<82from the runtime dependencies. Nothing in flytekit, its plugins or its tests importspkg_resources,setuptoolsordistutils. The[build-system]requirement is unchanged.setuptools<82to theydata-profilingandallextras and to its dev requirements. ydata-profiling (latest 4.18.4) still importspkg_resourceswithout declaring setuptools, so it had only worked because flytekit pulled setuptools in.How was this patch tested?
Installed
dev-requirements.inthe waymake setup-global-uvdoes. That resolved setuptools 84.2.1 (which has nopkg_resources) and marshmallow-jsonschema 0.16.0. Themake unit_testselection passes: 1964 passed, 23 skipped.tests/flytekit/unit/coreandtypesalso pass, includingtest_type_engine.py, which importsmarshmallow_jsonschemadirectly. flytekit-deck-standard tests pass with the new pin (10 passed).Check all the applicable boxes
Related PRs
#3388, #3430