Skip to content

Commit 2ee51a5

Browse files
committed
Drop the dead sentiment exclusion list and the values override (v2.9.14)
`view/common/resource-page-block-layout/values.phtml` passed `displayValues()` an `excludeProperties` list of 18 hardcoded generation-1 AI-sentiment terms (iwac:gemini* / chatgpt* / mistral*). That list has not kept the properties off the page for some time: IwacVisualizations strips them server-side from a `rep.resource.display_values` listener driven by `Module::SENTIMENT_MODEL_STEMS`, which covers eleven annotator families across both annotation generations — including the generation-2 slots (gpt56Luna, mistralSmall2603, deepseekV4Flash0731, gemma431bIt) the theme's list never learned about. With the list gone the override was byte-for-byte core's partial — an empty `$options`, the `exclude_resources_not_in_site` siteId branch, `echo $resource->displayValues($options)` — so it is deleted rather than kept as a duplicate that has to be rebased on every core change. `components/sentiment/_sentiment.scss` went with it. It had held the `display:none` rules the server-side exclusion replaced, and since then was an empty file whose only content was a docblock pointing at the list above; its `@forward` and the README sass tree are updated to match, and the build confirms no CSS change. A CLAUDE.md gotcha records where the exclusion actually lives, so the next reader does not reintroduce a theme-side list that can only fall behind the next model rename. ROADMAP C1 cited the removed `displayValues` option as the reason for the ^4.2.0 floor; the floor stands on the theme-provided `resource_page_block_layouts` instead.
1 parent 903164d commit 2ee51a5

10 files changed

Lines changed: 20 additions & 74 deletions

File tree

CITATION.cff

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ authors:
2727
given-names: Frédérick
2828
orcid: "https://orcid.org/0000-0003-0959-2092"
2929
affiliation: "University of Bayreuth"
30-
version: "2.9.13"
31-
date-released: "2026-08-12"
30+
version: "2.9.14"
31+
date-released: "2026-08-14"
3232
license: GPL-3.0-or-later
3333
repository-code: "https://github.com/fmadore/IWAC-theme"
3434
url: "https://islam.zmo.de/s/westafrica/"

CLAUDE.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,18 @@ Omeka modules ship their own markup and vendor CSS (tablesaw; RightsStatements i
8181
`height:4em`). Selectors written against assumed markup silently match nothing, and a
8282
vendor `max-width: 100%` beats your `min-width`.
8383

84+
### The AI-sentiment properties are hidden by IwacVisualizations, not by the theme
85+
86+
The `iwac:*Centralite` / `*Polarite` / `*SubjectiviteScore` terms and their
87+
`*Justification` siblings never reach the public value list: IwacVisualizations listens on
88+
`rep.resource.display_values` and strips every annotator family it knows about
89+
(`Module::SENTIMENT_MODEL_STEMS`), across both annotation generations. The theme has no
90+
part in it — no `excludeProperties` list, no `display:none` rule, no
91+
`components/sentiment/` partial. All three existed once and all three were dead by the
92+
time they were removed in 2.9.14; a hardcoded list here can only fall behind the next
93+
model rename. If a sentiment field shows up on an item page, the fix belongs in the
94+
module's stem list.
95+
8496
### Mirador only shows file-backed media — everything else needs its own block
8597

8698
The live sites' resource-page stack uses the Mirador module's block in place of core's

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ sass/
165165
│ ├── hierarchy, iframe-embed, linked-resources, local-contexts
166166
│ ├── mapping, metadata, mirador, navigation, pagination
167167
│ ├── resources/ # resource-grid, resource-list, browse-controls
168-
│ └── search-results, sentiment, uri-dereferencer, user-bar
168+
│ └── search-results, uri-dereferencer, user-bar
169169
├── generic/ # Box-sizing, normalize
170170
└── utilities/ # Accessibility, alignments, clearfix, print
171171
```

ROADMAP.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ Legend: `[x]` done · `[ ]` open · `[~]` deferred (rationale inline).
179179
## Phase 7 — Build, config & guardrails
180180

181181
- [x] **C1** Align the Omeka version floor everywhere at `^4.2.0` (theme.ini already
182-
enforces it; `values.phtml` relies on a 4.2-only `displayValues` option) —
182+
enforces it, and its theme-provided `resource_page_block_layouts` are 4.2-only) —
183183
composer.json, README, CLAUDE.md, `style.scss` header.
184184
- [x] **C2** composer.json: drop the unresolvable `require: omeka/omeka-s`; align the
185185
SPDX license id with package.json (`GPL-3.0-or-later`).

asset/sass/components/_components.scss

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -87,10 +87,6 @@
8787
--------------------------------------------- */
8888
@forward "search-results/search-results";
8989

90-
/* Sentiment Analysis (IwacSentiment module)
91-
--------------------------------------------- */
92-
@forward "sentiment/sentiment";
93-
9490
/* URI Dereferencer
9591
--------------------------------------------- */
9692
@forward "uri-dereferencer/uri-dereferencer";

asset/sass/components/sentiment/_sentiment.scss

Lines changed: 0 additions & 21 deletions
This file was deleted.

config/theme.ini

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[info]
22
name = "IWAC Theme"
3-
version = "2.9.13"
3+
version = "2.9.14"
44
author = "Frédérick Madore"
55
description = "Islam West Africa Collection Theme - A customized Omeka S theme for the IWAC digital collection at ZMO Berlin. Features light/dark mode toggle and multilingual support."
66
theme_link = "https://github.com/fmadore/IWAC-theme"

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "iwac-theme",
3-
"version": "2.9.13",
3+
"version": "2.9.14",
44
"description": "Islam West Africa Collection Theme - A customized Omeka S theme for the IWAC digital collection.",
55
"main": "gulpfile.js",
66
"scripts": {

view/common/resource-page-block-layout/values.phtml

Lines changed: 0 additions & 41 deletions
This file was deleted.

0 commit comments

Comments
 (0)