Commit 2ee51a5
committed
Drop the dead sentiment exclusion list and the values override (v2.9.14)
`view/common/resource-page-block-layout/values.phtml` passed
`displayValues()` an `excludeProperties` list of 18 hardcoded
generation-1 AI-sentiment terms (iwac:gemini* / chatgpt* / mistral*).
That list has not kept the properties off the page for some time:
IwacVisualizations strips them server-side from a
`rep.resource.display_values` listener driven by
`Module::SENTIMENT_MODEL_STEMS`, which covers eleven annotator families
across both annotation generations — including the generation-2 slots
(gpt56Luna, mistralSmall2603, deepseekV4Flash0731, gemma431bIt) the
theme's list never learned about.
With the list gone the override was byte-for-byte core's partial — an
empty `$options`, the `exclude_resources_not_in_site` siteId branch,
`echo $resource->displayValues($options)` — so it is deleted rather than
kept as a duplicate that has to be rebased on every core change.
`components/sentiment/_sentiment.scss` went with it. It had held the
`display:none` rules the server-side exclusion replaced, and since then
was an empty file whose only content was a docblock pointing at the
list above; its `@forward` and the README sass tree are updated to
match, and the build confirms no CSS change.
A CLAUDE.md gotcha records where the exclusion actually lives, so the
next reader does not reintroduce a theme-side list that can only fall
behind the next model rename. ROADMAP C1 cited the removed
`displayValues` option as the reason for the ^4.2.0 floor; the floor
stands on the theme-provided `resource_page_block_layouts` instead.1 parent 903164d commit 2ee51a5
10 files changed
Lines changed: 20 additions & 74 deletions
File tree
- asset/sass/components
- sentiment
- config
- view/common/resource-page-block-layout
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
31 | | - | |
| 30 | + | |
| 31 | + | |
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
84 | 96 | | |
85 | 97 | | |
86 | 98 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
165 | 165 | | |
166 | 166 | | |
167 | 167 | | |
168 | | - | |
| 168 | + | |
169 | 169 | | |
170 | 170 | | |
171 | 171 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
179 | 179 | | |
180 | 180 | | |
181 | 181 | | |
182 | | - | |
| 182 | + | |
183 | 183 | | |
184 | 184 | | |
185 | 185 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
87 | 87 | | |
88 | 88 | | |
89 | 89 | | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | 90 | | |
95 | 91 | | |
96 | 92 | | |
| |||
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
This file was deleted.
0 commit comments