Skip to content

Add branch filter and consolidate by option in Employee Leave Balance - #5150

Open
akhtarmohsin wants to merge 2 commits into
frappe:developfrom
akhtarmohsin:employee-leave-balance-report-enhancements
Open

Add branch filter and consolidate by option in Employee Leave Balance#5150
akhtarmohsin wants to merge 2 commits into
frappe:developfrom
akhtarmohsin:employee-leave-balance-report-enhancements

Conversation

@akhtarmohsin

@akhtarmohsin akhtarmohsin commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add a Branch filter and Branch column to the Employee Leave Balance report.
  • Change the Consolidate Leave Types checkbox to a Consolidate By dropdown. It now has two options: Leave Type and Employee.

Test plan

  • Open Employee Leave Balance report.
  • Filter by Branch and check the Branch column shows correct data.
  • Set Consolidate By to Leave Type and check rows group by leave type.
  • Set Consolidate By to Employee and check rows group by employee.
Screen.Recording.2026-08-25.at.6.13.47.PM.mov

@greptile-apps

greptile-apps Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 4/5

The PR is not safe to merge until legacy saved filters retain leave-type consolidation.

A legacy consolidate_leave_types=1 request still produces expanded employee-by-leave rows because the backend only checks the new consolidate_by field.

Files Needing Attention: hrms/hr/report/employee_leave_balance/employee_leave_balance.py

Reviews (4): Last reviewed commit: "test(employee_leave_balance): expect bra..." | Re-trigger Greptile

Comment thread hrms/hr/report/employee_leave_balance/employee_leave_balance.py Outdated
@akhtarmohsin
akhtarmohsin force-pushed the employee-leave-balance-report-enhancements branch from 799b407 to 8f7b014 Compare August 25, 2026 10:37
…e by option

Add a Branch filter and column, and change the Consolidate Leave Types
checkbox to a Consolidate By select with Leave Type and Employee options.
@akhtarmohsin
akhtarmohsin force-pushed the employee-leave-balance-report-enhancements branch from 8f7b014 to 665ea8c Compare August 25, 2026 10:44
@mergify

mergify Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Update the existing unit test to include the new branch field added
to the Employee Leave Balance report rows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant