Repository navigation
Calibration correctness: pool tied similarity scores before isotonic regression - #88
Merged
fraware merged 2 commits intoAug 25, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-freeze research/software correction only. Empirical
mainand all physical campaign semantics remain untouched.The existing isotonic implementation initialized one PAV block per sample. For conflicting labels at exactly the same similarity score, that allowed pair-ID tie ordering to change the fitted probability at that score. That is not a valid property for a calibrator whose predictor is the score itself.
This PR:
sonic-twin-isotonic-calibration-1tosonic-twin-isotonic-calibration-2while keeping schema version 1;No physical calibration evidence exists. These changes improve the correctness of software-only calibration mechanics and do not promote any Sonic Twin identity claim.