Skip to content

Test infrastructure: wait for Chromium before profile cleanup #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fraware merged 1 commit into from
Aug 25, 2026
Merged

Test infrastructure: wait for Chromium before profile cleanup #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions scripts/consumer-history-e2e.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ const chrome = spawn(browser, [
`--user-data-dir=${profileDir}`,
`${baseUrl}/`,
], { stdio: ["ignore", "ignore", "pipe"] });
const chromeExit = new Promise((resolve) => chrome.once("exit", resolve));

let stderr = "";
chrome.stderr.on("data", (chunk) => { stderr += String(chunk); });
Expand Down Expand Up @@ -151,6 +152,18 @@ async function waitFor(expression, label, timeoutMs = 18_000) {
throw new Error(`Timed out waiting for ${label}. Body: ${await evaluate("document.body?.innerText ?? ''")}`);
}

async function terminateChrome() {
if (chrome.exitCode !== null || chrome.signalCode !== null) return;
chrome.kill("SIGTERM");
const exitedGracefully = await Promise.race([
chromeExit.then(() => true),
sleep(2_000).then(() => false),
]);
if (exitedGracefully) return;
chrome.kill("SIGKILL");
await Promise.race([chromeExit, sleep(1_000)]);
}

async function layoutAudit() {
return evaluate(`(() => {
const buttons = Array.from(document.querySelectorAll("button")).filter((button) => {
Expand Down Expand Up @@ -368,7 +381,11 @@ try {
console.log("Consumer history E2E passed: strike → fingerprint-only storage → reload → saved player → distinct equal-signature observations → Resonance Diff A/B → zero microphone reacquisition → share → remove on 390×844 viewport.");
} finally {
try { socket.close(); } catch { /* already closed */ }
chrome.kill("SIGTERM");
await sleep(100);
rmSync(workDir, { recursive: true, force: true });
await terminateChrome();
try {
rmSync(workDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
} catch (error) {
const detail = error instanceof Error ? error.message : String(error);
console.warn(`Browser profile cleanup deferred after completed history assertions: ${detail}`);
}
}
Loading